mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-16 23:39:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Notify canvas context when width or height attribute is changed

Browse source
This commit is contained in:
Gingeh 2024-12-28 15:47:58 +11:00 • committed by Andreas Kling
commit 42a8effae5
Notes: github-actions[bot] 2024-12-28 09:38:07 +00:00
4 changed files with 26 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Libraries/LibWeb/HTML/HTMLCanvasElement.cpp
View file

@ -185,6 +185,16 @@ WebIDL::ExceptionOr<void> HTMLCanvasElement::set_height(WebIDL::UnsignedLong val
return {}; return {};
} }
void HTMLCanvasElement::attribute_changed(FlyString const& local_name, Optional<String> const& old_value, Optional<String> const& value, Optional<FlyString> const& namespace_)
{
Base::attribute_changed(local_name, old_value, value, namespace_);
if (local_name.equals_ignoring_ascii_case(HTML::AttributeNames::width) || local_name.equals_ignoring_ascii_case(HTML::AttributeNames::height)) {
notify_context_about_canvas_size_change();
reset_context_to_default_state();
}
}
GC::Ptr<Layout::Node> HTMLCanvasElement::create_layout_node(GC::Ref<CSS::ComputedProperties> style) GC::Ptr<Layout::Node> HTMLCanvasElement::create_layout_node(GC::Ref<CSS::ComputedProperties> style)
{ {
return heap().allocate<Layout::CanvasBox>(document(), *this, move(style)); return heap().allocate<Layout::CanvasBox>(document(), *this, move(style));

2
Libraries/LibWeb/HTML/HTMLCanvasElement.h
View file

@ -38,6 +38,8 @@ public:
WebIDL::ExceptionOr<void> set_width(WebIDL::UnsignedLong); WebIDL::ExceptionOr<void> set_width(WebIDL::UnsignedLong);
WebIDL::ExceptionOr<void> set_height(WebIDL::UnsignedLong); WebIDL::ExceptionOr<void> set_height(WebIDL::UnsignedLong);
virtual void attribute_changed(FlyString const& local_name, Optional<String> const& old_value, Optional<String> const& value, Optional<FlyString> const& namespace_) override;
String to_data_url(StringView type, JS::Value quality); String to_data_url(StringView type, JS::Value quality);
WebIDL::ExceptionOr<void> to_blob(GC::Ref<WebIDL::CallbackType> callback, StringView type, JS::Value quality); WebIDL::ExceptionOr<void> to_blob(GC::Ref<WebIDL::CallbackType> callback, StringView type, JS::Value quality);

1
Tests/LibWeb/Text/expected/canvas-changed-width-attribute.txt Normal file
View file

@ -0,0 +1 @@
PASS (didn't crash)

13
Tests/LibWeb/Text/input/canvas-changed-width-attribute.html Normal file
View file

@ -0,0 +1,13 @@
<!DOCTYPE html>
<script src="include.js"></script>
<script>
test(() => {
const canvas = document.createElement("canvas");
const ctx = canvas.getContext("2d");
canvas.setAttribute("width", "0");
canvas.toDataURL();
println("PASS (didn't crash)");
});
</script>