mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-19 08:51:57 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Add Range::for_each_contained()

Browse source 
This centralizes the logic for iterating over a Range's contained nodes.
This commit is contained in:
Jelle Raaijmakers 2025-01-09 10:20:07 +01:00 • committed by Andreas Kling
commit 4323669939
Notes: github-actions[bot] 2025-01-10 22:39:13 +00:00
5 changed files with 44 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Libraries/LibWeb/DOM/Range.cpp
View file

@ -578,10 +578,11 @@ String Range::to_string() const
}
// 4. Append the concatenation of the data of all Text nodes that are contained in this, in tree order, to s.
for (GC::Ptr<Node> node = start_container(); node != end_container()->next_sibling(); node = node->next_in_pre_order()) {
if (is<Text>(*node) && contains_node(*node))
for_each_contained([&](GC::Ref<DOM::Node> node) {
if (is<Text>(*node))
builder.append(static_cast<Text const&>(*node).data());
}
return IterationDecision::Continue;
});
// 5. If this’s end node is a Text node, then append the substring of that node’s data from its start until this’s end offset to s.
if (is<Text>(*end_container())) {

26
Libraries/LibWeb/DOM/Range.h
View file

@ -2,7 +2,7 @@
* Copyright (c) 2020, the SerenityOS developers.
* Copyright (c) 2022, Luke Wilde <lukew@serenityos.org>
* Copyright (c) 2022-2023, Andreas Kling <andreas@ladybird.org>
* Copyright (c) 2024, Jelle Raaijmakers <jelle@ladybird.org>
* Copyright (c) 2024-2025, Jelle Raaijmakers <jelle@ladybird.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -10,6 +10,7 @@
#pragma once
#include <LibWeb/DOM/AbstractRange.h>
#include <LibWeb/DOM/Node.h>
#include <LibWeb/Selection/Selection.h>
#include <LibWeb/WebIDL/Types.h>
@ -98,6 +99,29 @@ public:
WebIDL::ExceptionOr<GC::Ref<DocumentFragment>> create_contextual_fragment(String const& fragment);
template<typename Callback>
void for_each_contained(Callback callback) const
{
return const_cast<Range*>(this)->for_each_contained(move(callback));
}
template<typename Callback>
void for_each_contained(Callback callback)
{
GC::Ptr<Node> end = m_end_container;
while (end && !end->next_sibling())
end = end->parent();
if (end)
end = end->next_sibling();
for (GC::Ptr<Node> node = m_start_container; node && node != end; node = node->next_in_pre_order()) {
if (contains_node(*node)) {
if (callback(*node) == IterationDecision::Break)
return;
}
}
}
private:
explicit Range(Document&);
Range(GC::Ref<Node> start_container, WebIDL::UnsignedLong start_offset, GC::Ref<Node> end_container, WebIDL::UnsignedLong end_offset);