mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 04:09:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Remove a bunch of redundant Document::navigable() lookups

Browse source 
Document::navigable() can be unpleasantly slow, since we don't have a
direct link between documents and navigables at the moment. So let's not
call it twice when once is enough.
This commit is contained in:
Andreas Kling 2024-03-16 09:24:57 +01:00
commit 43c720db81
Notes: sideshowbarker 2024-07-17 02:06:40 +09:00
4 changed files with 21 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/HTML/EventLoop/EventLoop.cpp
View file

@ -158,7 +158,8 @@ void EventLoop::process()
// 2. Rendering opportunities: Remove from docs all Document objects whose node navigables do not have a rendering opportunity.
docs.remove_all_matching([&](auto& document) {
return document->navigable() && !document->navigable()->has_a_rendering_opportunity();
auto navigable = document->navigable();
return navigable && !navigable->has_a_rendering_opportunity();
});
// 3. If docs is not empty, then set hasARenderingOpportunity to true
@ -254,7 +255,8 @@ void EventLoop::process()
// 16. For each fully active Document in docs, update the rendering or user interface of that Document and its browsing context to reflect the current state.
for_each_fully_active_document_in_docs([&](DOM::Document& document) {
if (document.navigable() && document.navigable()->needs_repaint()) {
auto navigable = document.navigable();
if (navigable && navigable->needs_repaint()) {
auto* browsing_context = document.browsing_context();
auto& page = browsing_context->page();
page.client().schedule_repaint();