mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-30 20:59:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Implement Document's supported property names closer to the spec

Browse source 
Our implementation was errantly matching HTML tags other than the list
specified by the spec. For example, a <meta name=title> tag would be a
match for document.title.

For example, bandcamp will dynamically update its title when audio is
played as follows:

    document.title = "▶︎ " + document.title;

And bandcamp also has a <meta name=title> tag. The result was that the
title would become "▶︎ [object HTMLMetaElement]".
This commit is contained in:
Timothy Flynn 2024-03-29 07:20:16 -04:00 • committed by Tim Flynn
commit 43e55668eb
Notes: sideshowbarker 2024-07-17 02:06:40 +09:00
5 changed files with 76 additions and 59 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Tests/LibWeb/Text/expected/DOM/Document-named-properties.txt
View file

@ -1,4 +1,4 @@
Submit <FORM >
Submit <FORM >
document.bob === document.forms[0]: true
<BUTTON id="fred" >
img element with name 'foo' and id 'bar':
@ -14,3 +14,4 @@ obj element with name 'greg' and id 'banana':
<OBJECT id="banana" >
goodbye greg/banana
no more greg or banana: true, true
meta tag does not match: true