mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-27 06:48:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Don't store reference to temporary in resolve_module_specifier

Browse source 
An environment settings object will return a copy to the URL. From a
quick glance, we could probably make an environment settings object
return a reference to one, but let's just change this code to make
a copy since its not safe to rely on that.
This commit is contained in:
Shannon Booth 2024-11-25 09:48:23 +13:00 • committed by Andrew Kaster
parent 7b678d3e1f
commit 43f75dcba0
Notes: github-actions[bot] 2024-11-24 22:31:00 +00:00
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibWeb/HTML/Scripting/Fetching.cpp
View file

@ -85,8 +85,8 @@ ByteString module_type_from_module_request(JS::ModuleRequest const& module_reque
WebIDL::ExceptionOr<URL::URL> resolve_module_specifier(Optional<Script&> referring_script, ByteString const& specifier)
{
// 1. Let settingsObject and baseURL be null.
Optional<EnvironmentSettingsObject&> settings_object;
Optional<URL::URL const&> base_url;
GC::Ptr<EnvironmentSettingsObject> settings_object;
Optional<URL::URL> base_url;
// 2. If referringScript is not null, then:
if (referring_script.has_value()) {