diff --git a/Kernel/CommandLine.cpp b/Kernel/CommandLine.cpp index 4294b97c9ca..007af0e7064 100644 --- a/Kernel/CommandLine.cpp +++ b/Kernel/CommandLine.cpp @@ -108,9 +108,14 @@ UNMAP_AFTER_INIT bool CommandLine::is_vmmouse_enabled() const return lookup("vmmouse").value_or("on") == "on"; } -UNMAP_AFTER_INIT bool CommandLine::is_mmio_enabled() const +UNMAP_AFTER_INIT bool CommandLine::is_pci_ecam_enabled() const { - return lookup("pci_mmio").value_or("off") == "on"; + auto value = lookup("pci_ecam").value_or("on"); + if (value == "on") + return true; + if (value == "off") + return false; + PANIC("Unknown PCI ECAM setting: {}", value); } UNMAP_AFTER_INIT bool CommandLine::is_legacy_time_enabled() const diff --git a/Kernel/CommandLine.h b/Kernel/CommandLine.h index 91e553026ec..ed5d632b3e3 100644 --- a/Kernel/CommandLine.h +++ b/Kernel/CommandLine.h @@ -71,7 +71,7 @@ public: [[nodiscard]] bool is_ide_enabled() const; [[nodiscard]] bool is_smp_enabled() const; [[nodiscard]] bool is_vmmouse_enabled() const; - [[nodiscard]] bool is_mmio_enabled() const; + [[nodiscard]] bool is_pci_ecam_enabled() const; [[nodiscard]] bool is_legacy_time_enabled() const; [[nodiscard]] bool is_text_mode() const; [[nodiscard]] bool is_force_pio() const; diff --git a/Kernel/PCI/Initializer.cpp b/Kernel/PCI/Initializer.cpp index d010c5fd092..98a660c59ff 100644 --- a/Kernel/PCI/Initializer.cpp +++ b/Kernel/PCI/Initializer.cpp @@ -50,7 +50,7 @@ UNMAP_AFTER_INIT static Access::Type detect_optimal_access_type(bool mmio_allowe UNMAP_AFTER_INIT void initialize() { - bool mmio_allowed = kernel_command_line().is_mmio_enabled(); + bool mmio_allowed = kernel_command_line().is_pci_ecam_enabled(); if (detect_optimal_access_type(mmio_allowed) == Access::Type::MMIO) MMIOAccess::initialize(ACPI::Parser::the()->find_table("MCFG")); diff --git a/Kernel/PCI/MMIOAccess.cpp b/Kernel/PCI/MMIOAccess.cpp index 702f85aa873..1aabc5f1c1c 100644 --- a/Kernel/PCI/MMIOAccess.cpp +++ b/Kernel/PCI/MMIOAccess.cpp @@ -126,7 +126,7 @@ UNMAP_AFTER_INIT MMIOAccess::MMIOAccess(PhysicalAddress p_mcfg) }); } -UNMAP_AFTER_INIT Optional MMIOAccess::get_device_configuration_space(Address address) +Optional MMIOAccess::get_device_configuration_space(Address address) { dbgln_if(PCI_DEBUG, "PCI: Getting device configuration space for {}", address); for (auto& mapping : m_mapped_device_regions) {