mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-02 23:56:06 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

HexEditor: Fixed off-by-one copying bug

Browse source 
When copying as hex or text we missed the last byte.
This commit is contained in:
Brandon Scott 2019-10-20 23:55:42 -05:00 • committed by Andreas Kling
commit 443eda986a
Notes: sideshowbarker 2024-07-19 11:36:21 +09:00
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Applications/HexEditor/HexEditor.cpp
View file

@ -93,7 +93,7 @@ bool HexEditor::copy_selected_hex_to_clipboard()
return false; return false;
StringBuilder output_string_builder; StringBuilder output_string_builder;
for (int i = m_selection_start; i < m_selection_end; i++) { for (int i = m_selection_start; i <= m_selection_end; i++) {
output_string_builder.appendf("%02X ", m_buffer.data()[i]); output_string_builder.appendf("%02X ", m_buffer.data()[i]);
} }
@ -107,7 +107,7 @@ bool HexEditor::copy_selected_text_to_clipboard()
return false; return false;
StringBuilder output_string_builder; StringBuilder output_string_builder;
for (int i = m_selection_start; i < m_selection_end; i++) { for (int i = m_selection_start; i <= m_selection_end; i++) {
output_string_builder.appendf("%c", isprint(m_buffer.data()[i]) ? m_buffer[i] : '.'); output_string_builder.appendf("%c", isprint(m_buffer.data()[i]) ? m_buffer[i] : '.');
} }