mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-07-29 04:09:13 +00:00
LibWeb: Cache the qualified layer name in CSSRule
This makes cascade layer filtering take <2% of CPU time when loading https://vercel.com instead of 30%.
This commit is contained in:
parent
95bd0602ba
commit
44e4ea3d7a
Notes:
github-actions[bot]
2024-09-07 11:24:51 +00:00
Author: https://github.com/awesomekling
Commit: 44e4ea3d7a
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/1312
Reviewed-by: https://github.com/AtkinsSJ
4 changed files with 33 additions and 31 deletions
|
@ -48,37 +48,39 @@ void CSSRule::set_parent_style_sheet(CSSStyleSheet* parent_style_sheet)
|
|||
m_parent_style_sheet = parent_style_sheet;
|
||||
}
|
||||
|
||||
String CSSRule::parent_layer_internal_qualified_name() const
|
||||
FlyString const& CSSRule::parent_layer_internal_qualified_name() const
|
||||
{
|
||||
// TODO: Cache this?
|
||||
Vector<FlyString> layer_names;
|
||||
for (auto* rule = parent_rule(); rule; rule = rule->parent_rule()) {
|
||||
switch (rule->type()) {
|
||||
case CSSRule::Type::Import:
|
||||
// TODO: Handle `layer(foo)` in import rules once we implement that.
|
||||
break;
|
||||
if (!m_cached_layer_name.has_value()) {
|
||||
Vector<FlyString> layer_names;
|
||||
for (auto* rule = parent_rule(); rule; rule = rule->parent_rule()) {
|
||||
switch (rule->type()) {
|
||||
case CSSRule::Type::Import:
|
||||
// TODO: Handle `layer(foo)` in import rules once we implement that.
|
||||
break;
|
||||
|
||||
case CSSRule::Type::LayerBlock: {
|
||||
auto& layer_block = static_cast<CSSLayerBlockRule const&>(*rule);
|
||||
layer_names.append(layer_block.internal_name());
|
||||
break;
|
||||
case CSSRule::Type::LayerBlock: {
|
||||
auto& layer_block = static_cast<CSSLayerBlockRule const&>(*rule);
|
||||
layer_names.append(layer_block.internal_name());
|
||||
break;
|
||||
}
|
||||
|
||||
// Ignore everything else
|
||||
// Note that LayerStatement cannot have child rules so we still ignore it here.
|
||||
case CSSRule::Type::LayerStatement:
|
||||
case CSSRule::Type::Style:
|
||||
case CSSRule::Type::Media:
|
||||
case CSSRule::Type::FontFace:
|
||||
case CSSRule::Type::Keyframes:
|
||||
case CSSRule::Type::Keyframe:
|
||||
case CSSRule::Type::Namespace:
|
||||
case CSSRule::Type::Supports:
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
||||
// Ignore everything else
|
||||
// Note that LayerStatement cannot have child rules so we still ignore it here.
|
||||
case CSSRule::Type::LayerStatement:
|
||||
case CSSRule::Type::Style:
|
||||
case CSSRule::Type::Media:
|
||||
case CSSRule::Type::FontFace:
|
||||
case CSSRule::Type::Keyframes:
|
||||
case CSSRule::Type::Keyframe:
|
||||
case CSSRule::Type::Namespace:
|
||||
case CSSRule::Type::Supports:
|
||||
break;
|
||||
}
|
||||
m_cached_layer_name = MUST(String::join("."sv, layer_names.in_reverse()));
|
||||
}
|
||||
|
||||
return MUST(String::join("."sv, layer_names.in_reverse()));
|
||||
return m_cached_layer_name.value();
|
||||
}
|
||||
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue