LibJS: Throw TypeError when coercing symbol to number

Author: https://github.com/linusg
Commit: 4569e88bea
Pull-request: https://github.com/SerenityOS/serenity/pull/2270
Issue: https://github.com/SerenityOS/serenity/issues/2267

Libraries/LibJS/Runtime/Value.cpp

@@ -231,8 +231,8 @@ Value Value::to_number(Interpreter& interpreter) const
         return Value(parsed_double);
     }
     case Type::Symbol:
-        // FIXME: Get access to the interpreter and throw a TypeError
+        interpreter.throw_exception<TypeError>("Can't convert symbol to number");
-        ASSERT_NOT_REACHED();
+        return {};
     case Type::Object:
         auto primitive = m_value.as_object->to_primitive(Object::PreferredType::Number);
         if (interpreter.exception())

Libraries/LibJS/Tests/Symbol.prototype.toString.js

@@ -14,13 +14,12 @@ try {
         message: "Can't convert symbol to string",
     });
     
-    // FIXME: Uncomment when this doesn't assert
+    assertThrowsError(() => {
-    // assertThrowsError(() => {
+        s1 + 1;
-    //     s1 + 1;
+    }, {
-    // }, {
+        error: TypeError,
-    //     error: TypeError,
+        message: "Can't convert symbol to number",
-    //     message: "Can't convert symbol to number",
+    });
-    // });
     
     console.log("PASS");
 } catch (e) {