mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-08 01:00:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Flip vertically PaintingSurface attached to WebGL context

Browse source 
OpenGL's origin is at the bottom-left corner, while Skia's origin is at
the top-left corner. This change adds a transformation to compensate for
this difference when rendering PaintingSurface attached to WebGL
context.
This commit is contained in:
Aliaksandr Kalenik 2024-11-30 16:52:09 +01:00 • committed by Alexander Kalenik
commit 45e0f50463
Notes: github-actions[bot] 2024-12-03 22:37:23 +00:00
3 changed files with 15 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibGfx/PaintingSurface.h
View file

@ -45,6 +45,9 @@ public:
void flush() const; void flush() const;
bool flip_vertically() const { return m_flip_vertically; }
void set_flip_vertically() { m_flip_vertically = true; }
~PaintingSurface(); ~PaintingSurface();
private: private:
@ -53,6 +56,7 @@ private:
PaintingSurface(NonnullOwnPtr<Impl>&&); PaintingSurface(NonnullOwnPtr<Impl>&&);
NonnullOwnPtr<Impl> m_impl; NonnullOwnPtr<Impl> m_impl;
bool m_flip_vertically { false };
}; };
} }

10
Libraries/LibWeb/Painting/DisplayListPlayerSkia.cpp
View file

@ -329,7 +329,17 @@ void DisplayListPlayerSkia::draw_painting_surface(DrawPaintingSurface const& com
auto& canvas = surface().canvas(); auto& canvas = surface().canvas();
auto image = sk_surface.makeImageSnapshot(); auto image = sk_surface.makeImageSnapshot();
SkPaint paint; SkPaint paint;
if (command.surface->flip_vertically()) {
canvas.save();
SkMatrix matrix;
matrix.setIdentity();
matrix.preScale(1, -1, dst_rect.centerX(), dst_rect.centerY());
canvas.concat(matrix);
}
canvas.drawImageRect(image, src_rect, dst_rect, to_skia_sampling_options(command.scaling_mode), &paint, SkCanvas::kStrict_SrcRectConstraint); canvas.drawImageRect(image, src_rect, dst_rect, to_skia_sampling_options(command.scaling_mode), &paint, SkCanvas::kStrict_SrcRectConstraint);
if (command.surface->flip_vertically()) {
canvas.restore();
}
} }
void DisplayListPlayerSkia::draw_scaled_immutable_bitmap(DrawScaledImmutableBitmap const& command) void DisplayListPlayerSkia::draw_scaled_immutable_bitmap(DrawScaledImmutableBitmap const& command)

1
Libraries/LibWeb/WebGL/OpenGLContext.cpp
View file

@ -122,6 +122,7 @@ void OpenGLContext::allocate_painting_surface_if_needed()
auto iosurface = Core::IOSurfaceHandle::create(m_size.width(), m_size.height()); auto iosurface = Core::IOSurfaceHandle::create(m_size.width(), m_size.height());
m_painting_surface = Gfx::PaintingSurface::wrap_iosurface(iosurface, m_skia_backend_context); m_painting_surface = Gfx::PaintingSurface::wrap_iosurface(iosurface, m_skia_backend_context);
m_painting_surface->set_flip_vertically();
auto width = m_size.width(); auto width = m_size.width();
auto height = m_size.height(); auto height = m_size.height();