mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-05 07:41:01 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Resolve HTMLFormElement.action relative to document base URL

Browse source 
Rather than returning a relative URL, an absolutized URL is now
returned relative to the document base URL
This commit is contained in:
Tim Ledbetter 2024-09-08 00:51:59 +01:00 • committed by Andreas Kling
commit 48e5d28ec9
Notes: github-actions[bot] 2024-09-08 07:48:40 +00:00
3 changed files with 21 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Tests/LibWeb/Text/expected/HTML/HTMLFormElement-action.txt Normal file
View file

@ -0,0 +1,3 @@
form.action initial value: http://www.example.com/
Final segment of form.action after setting to the empty string: HTMLFormElement-action.html
Final segment of form.action after setting to "../test.html": test.html

14
Tests/LibWeb/Text/input/HTML/HTMLFormElement-action.html Normal file
View file

@ -0,0 +1,14 @@
<!DOCTYPE html>
<script src="../include.js"></script>
<form action="http://www.example.com/"></form>
<script>
test(() => {
const formElement = document.querySelector('form');
println(`form.action initial value: ${formElement.action}`);
formElement.action = "";
println(`Final segment of form.action after setting to the empty string: ${formElement.action.split('/').pop()}`);
formElement.action = "../test.html";
println(`Final segment of form.action after setting to "../test.html": ${formElement.action.split('/').pop()}`);
formElement.remove();
});
</script>

8
Userland/Libraries/LibWeb/HTML/HTMLFormElement.cpp
View file

@ -604,12 +604,12 @@ String HTMLFormElement::action() const
// The action IDL attribute must reflect the content attribute of the same name, except that on getting, when the // The action IDL attribute must reflect the content attribute of the same name, except that on getting, when the
// content attribute is missing or its value is the empty string, the element's node document's URL must be returned // content attribute is missing or its value is the empty string, the element's node document's URL must be returned
// instead. // instead.
if (auto maybe_action = attribute(AttributeNames::action); auto form_action_attribute = attribute(AttributeNames::action);
maybe_action.has_value() && !maybe_action.value().is_empty()) { if (!form_action_attribute.has_value() || form_action_attribute.value().is_empty()) {
return maybe_action.value(); return document().url_string();
} }
return MUST(document().url().to_string()); return MUST(document().base_url().complete_url(form_action_attribute.value()).to_string());
} }
// https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#dom-fs-action // https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#dom-fs-action