From 4904326244373a2820029771b5ef3e2f777f8bcc Mon Sep 17 00:00:00 2001 From: rmg-x Date: Mon, 10 Feb 2025 18:09:55 -0600 Subject: [PATCH] LibDNS: Fix check for cache entries that can be removed Co-authored-by: Ali Mohammad Pur --- Libraries/LibDNS/Resolver.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Libraries/LibDNS/Resolver.h b/Libraries/LibDNS/Resolver.h index 73cbe55ed65..6200ef86427 100644 --- a/Libraries/LibDNS/Resolver.h +++ b/Libraries/LibDNS/Resolver.h @@ -98,7 +98,7 @@ public: void set_id(u16 id) { m_id = id; } u16 id() { return m_id; } - bool is_valid() const { return m_valid && m_request_done; } + bool can_be_removed() const { return !m_valid && m_request_done; } Messages::DomainName const& name() const { return m_name; } private: @@ -518,7 +518,7 @@ private: HashTable to_remove; for (auto& entry : cache) { entry.value->check_expiration(); - if (!entry.value->is_valid()) + if (entry.value->can_be_removed()) to_remove.set(entry.key); } for (auto const& key : to_remove)