mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-05-28 14:02:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Get Page from principal realm during resource loading

Browse source 
Fixes a crash for module loading for a shadow realm.
This commit is contained in:
Shannon Booth 2024-11-25 10:37:28 +13:00 • committed by Andrew Kaster
parent b677844f8d
commit 4913dac745
Notes: github-actions[bot] 2024-11-24 22:30:46 +00:00
4 changed files with 13 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/Fetch/Fetching/Fetching.cpp
View file

@ -2240,7 +2240,7 @@ WebIDL::ExceptionOr<GC::Ref<PendingResponse>> nonstandard_resource_loader_file_o
auto request = fetch_params.request();
auto& page = Bindings::principal_host_defined_page(realm);
auto& page = Bindings::principal_host_defined_page(HTML::principal_realm(realm));
// NOTE: Using LoadRequest::create_for_url_on_page here will unconditionally add cookies as long as there's a page available.
// However, it is up to http_network_or_cache_fetch to determine if cookies should be added to the request.

1
Tests/LibWeb/Text/data/external-module.mjs Normal file
View file

@ -0,0 +1 @@
export const foo = "Well hello shadows";

1
Tests/LibWeb/Text/expected/HTML/ShadowRealm-importValue.txt Normal file
View file

@ -0,0 +1 @@
Well hello shadows

10
Tests/LibWeb/Text/input/HTML/ShadowRealm-importValue.html Normal file
View file

@ -0,0 +1,10 @@
<script src="../include.js"></script>
<script>
asyncTest(async done => {
const shadowRealm = new ShadowRealm();
const promise = shadowRealm.importValue("../../data/external-module.mjs", "foo");
const value = await promise;
println(value);
done();
});
</script>