mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-21 16:58:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/XHR: Remove outdated FIXME about Streams not integrated in XHR
Some checks are pending
CI / macOS, arm64, Sanitizer, Clang (push) Waiting to run
Details
CI / Linux, x86_64, Fuzzers, Clang (push) Waiting to run
Details
CI / Linux, x86_64, Sanitizer, GNU (push) Waiting to run
Details
CI / Linux, x86_64, Sanitizer, Clang (push) Waiting to run
Details
Package the js repl as a binary artifact / Linux, arm64 (push) Waiting to run
Details
Package the js repl as a binary artifact / macOS, arm64 (push) Waiting to run
Details
Package the js repl as a binary artifact / Linux, x86_64 (push) Waiting to run
Details
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Details
Lint Code / lint (push) Waiting to run
Details
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Details
Push notes / build (push) Waiting to run
Details

Browse source 
Streams were integrated into XHR::send() in: https://github.com/SerenityOS/serenity/pull/24132
This commit is contained in:
Kenneth Myhra 2025-08-21 18:57:41 +02:00 • committed by Tim Flynn
commit 4963dea504
Notes: github-actions[bot] 2025-08-26 11:19:59 +00:00
1 changed files with 0 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/XHR/XMLHttpRequest.cpp
View file

@ -808,8 +808,6 @@ WebIDL::ExceptionOr<void> XMLHttpRequest::send(Optional<DocumentOrXMLHttpRequest
if (!length.has<u64>()) if (!length.has<u64>())
length = 0; length = 0;
// FIXME: We can't implement these steps yet, as we don't fully implement the Streams standard.
// 10. Let processBodyChunk given bytes be these steps: // 10. Let processBodyChunk given bytes be these steps:
auto process_body_chunks = GC::create_function(heap(), [this, length](ByteBuffer byte_buffer) { auto process_body_chunks = GC::create_function(heap(), [this, length](ByteBuffer byte_buffer) {
// 1. Append bytes to this’s received bytes. // 1. Append bytes to this’s received bytes.