mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-30 14:20:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibDevTools: Add a helper to handle asynchronous request replies

Browse source 
This removes some boilerplate around executing async requests, such as
calling dbgln_if on any errors, handling weak pointers to `this`, and
dealing with block tokens.
This commit is contained in:
Timothy Flynn 2025-03-11 09:47:41 -04:00 • committed by Tim Flynn
commit 49adec1396
Notes: github-actions[bot] 2025-03-12 16:48:58 +00:00
9 changed files with 140 additions and 283 deletions
Download patch file Download diff file Expand all files Collapse all files

21
Libraries/LibDevTools/Actors/InspectorActor.cpp
View file

@ -58,22 +58,15 @@ void InspectorActor::handle_message(StringView type, JsonObject const& message)
if (type == "getWalker"sv) {
if (auto tab = m_tab.strong_ref()) {
auto block_token = block_responses();
devtools().delegate().inspect_tab(tab->description(),
[weak_self = make_weak_ptr<InspectorActor>(), block_token = move(block_token)](ErrorOr<JsonValue> dom_tree) mutable {
if (dom_tree.is_error()) {
dbgln_if(DEVTOOLS_DEBUG, "Unable to retrieve DOM tree: {}", dom_tree.error());
return;
}
if (!WalkerActor::is_suitable_for_dom_inspection(dom_tree.value())) {
async_handler<InspectorActor>([](auto& self, auto dom_tree, auto& response) {
if (!WalkerActor::is_suitable_for_dom_inspection(dom_tree)) {
dbgln_if(DEVTOOLS_DEBUG, "Did not receive a suitable DOM tree: {}", dom_tree);
return;
}
if (auto self = weak_self.strong_ref())
self->received_dom_tree(move(dom_tree.release_value().as_object()), move(block_token));
});
self.received_dom_tree(response, move(dom_tree.as_object()));
}));
}
return;
@ -88,7 +81,7 @@ void InspectorActor::handle_message(StringView type, JsonObject const& message)
send_unrecognized_packet_type_error(type);
}
void InspectorActor::received_dom_tree(JsonObject dom_tree, BlockToken block_token)
void InspectorActor::received_dom_tree(JsonObject& response, JsonObject dom_tree)
{
auto& walker_actor = devtools().register_actor<WalkerActor>(m_tab, move(dom_tree));
m_walker = walker_actor;
@ -97,9 +90,7 @@ void InspectorActor::received_dom_tree(JsonObject dom_tree, BlockToken block_tok
walker.set("actor"sv, walker_actor.name());
walker.set("root"sv, walker_actor.serialize_root());
JsonObject message;
message.set("walker"sv, move(walker));
send_message(move(message), move(block_token));
response.set("walker"sv, move(walker));
}
RefPtr<TabActor> InspectorActor::tab_for(WeakPtr<InspectorActor> const& weak_inspector)