mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-04-30 08:18:49 +00:00
LibWeb: Avoid allocating UTF-16 strings only the UTF-16 length is needed
This commit is contained in:
parent
7a17c654d2
commit
4a166a45ec
Notes:
github-actions[bot]
2024-07-31 09:56:31 +00:00
Author: https://github.com/trflynn89
Commit: 4a166a45ec
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/901
2 changed files with 4 additions and 6 deletions
|
@ -6,6 +6,7 @@
|
|||
* SPDX-License-Identifier: BSD-2-Clause
|
||||
*/
|
||||
|
||||
#include <AK/Utf16View.h>
|
||||
#include <LibWeb/Bindings/HTMLTextAreaElementPrototype.h>
|
||||
#include <LibWeb/Bindings/Intrinsics.h>
|
||||
#include <LibWeb/CSS/StyleProperties.h>
|
||||
|
@ -189,9 +190,7 @@ String HTMLTextAreaElement::api_value() const
|
|||
u32 HTMLTextAreaElement::text_length() const
|
||||
{
|
||||
// The textLength IDL attribute must return the length of the element's API value.
|
||||
// FIXME: This is inefficient!
|
||||
auto utf16_data = MUST(AK::utf8_to_utf16(api_value()));
|
||||
return Utf16View { utf16_data }.length_in_code_units();
|
||||
return AK::utf16_code_unit_length_from_utf8(api_value());
|
||||
}
|
||||
|
||||
// https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#dom-cva-checkvalidity
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue