mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-13 04:21:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

Kernel: Fix race between accept() and connect().

Browse source 
We had a bug where an accepted socket would appear to be EOF/disconnected
on the accepting side until the connecting side had called attach_fd().

Fix this by adding a new SocketRole::Connecting state.
This commit is contained in:
Andreas Kling 2019-03-20 02:33:51 +01:00
parent 31d3616027
commit 4aa0ab4e08
Notes: sideshowbarker 2024-07-19 14:59:59 +09:00
5 changed files with 14 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Kernel/FileDescriptor.cpp
View file

@ -76,8 +76,11 @@ void FileDescriptor::set_socket_role(SocketRole role)
return;
ASSERT(m_socket);
auto old_socket_role = m_socket_role;
m_socket_role = role;
m_socket->attach_fd(role);
if (old_socket_role != SocketRole::None)
m_socket->detach_fd(old_socket_role);
}
Retained<FileDescriptor> FileDescriptor::clone()