LibJS: Remove Object(Object& prototype) footgun

This constructor was easily confused with a copy constructor, and it was possible to accidentally copy-construct Objects in at least one way that we dicovered (via generic ThrowCompletionOr construction). This patch adds a mandatory ConstructWithPrototypeTag parameter to the constructor to disambiguate it.
Author: https://github.com/awesomekling Commit: 4abdb68655 Pull-request: https://github.com/SerenityOS/serenity/pull/16487 Reviewed-by: https://github.com/linusg ✅
2025-07-28 19:59:17 +00:00 · 2022-12-14 12:17:58 +01:00 · 2022-12-14 12:17:58 +01:00 · 4abdb68655 · 2024-07-17 03:15:34 +09:00
commit 4abdb68655
parent 42b5c896e8
90 changed files with 100 additions and 99 deletions
--- a/Userland/Libraries/LibJS/Runtime/BooleanObject.cpp
+++ b/Userland/Libraries/LibJS/Runtime/BooleanObject.cpp
@ -15,7 +15,7 @@ NonnullGCPtr<BooleanObject> BooleanObject::create(Realm& realm, bool value)
 }

 BooleanObject::BooleanObject(bool value, Object& prototype)
-    : Object(prototype)
+    : Object(ConstructWithPrototypeTag::Tag, prototype)
    , m_value(value)
 {
 }