mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-22 09:18:55 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Propagate use element width and height to the referenced element

Browse source
This commit is contained in:
Tim Ledbetter 2025-08-26 13:44:50 +01:00 • committed by Jelle Raaijmakers
commit 4acd517d8f
Notes: github-actions[bot] 2025-08-26 14:04:21 +00:00
3 changed files with 32 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Libraries/LibWeb/SVG/SVGUseElement.cpp
View file

@ -20,6 +20,7 @@
#include <LibWeb/SVG/AttributeNames.h> #include <LibWeb/SVG/AttributeNames.h>
#include <LibWeb/SVG/SVGDecodedImageData.h> #include <LibWeb/SVG/SVGDecodedImageData.h>
#include <LibWeb/SVG/SVGSVGElement.h> #include <LibWeb/SVG/SVGSVGElement.h>
#include <LibWeb/SVG/SVGSymbolElement.h>
#include <LibWeb/SVG/SVGUseElement.h> #include <LibWeb/SVG/SVGUseElement.h>
namespace Web::SVG { namespace Web::SVG {
@ -184,6 +185,20 @@ void SVGUseElement::clone_element_tree_as_our_shadow_tree(Element* to_clone)
if (to_clone && is_valid_reference_element(*to_clone)) { if (to_clone && is_valid_reference_element(*to_clone)) {
// The ‘use’ element references another element, a copy of which is rendered in place of the ‘use’ in the document. // The ‘use’ element references another element, a copy of which is rendered in place of the ‘use’ in the document.
auto cloned_reference_node = MUST(to_clone->clone_node(nullptr, true)); auto cloned_reference_node = MUST(to_clone->clone_node(nullptr, true));
if (is<SVGSVGElement>(cloned_reference_node.ptr()) || is<SVGSymbolElement>(cloned_reference_node.ptr())) {
auto& cloned_element = as<SVGElement>(*cloned_reference_node);
// The width and height properties on the ‘use’ element override the values for the corresponding
// properties on a referenced ‘svg’ or ‘symbol’ element when determining the used value for that property
// on the instance root element. However, if the computed value for the property on the ‘use’ element is
// auto, then the property is computed as normal for the element instance.
if (has_attribute(AttributeNames::width)) {
MUST(cloned_element.set_attribute(AttributeNames::width, get_attribute_value(AttributeNames::width)));
}
if (has_attribute(AttributeNames::height)) {
MUST(cloned_element.set_attribute(AttributeNames::height, get_attribute_value(AttributeNames::height)));
}
}
shadow_root()->append_child(cloned_reference_node).release_value_but_fixme_should_propagate_errors(); shadow_root()->append_child(cloned_reference_node).release_value_but_fixme_should_propagate_errors();
} }
} }

4
Tests/LibWeb/Ref/expected/svg/use-element-geometry-properties-ref.html Normal file
View file

@ -0,0 +1,4 @@
<!DOCTYPE html>
<svg width="100" height="100">
<rect width="100" height="100" fill="green"></rect>
</svg>

13
Tests/LibWeb/Ref/input/svg/use-element-geometry-properties.html Normal file
View file

@ -0,0 +1,13 @@
<!DOCTYPE html>
<link rel="match" href="../../expected/svg/use-element-geometry-properties-ref.html" />
<svg width="100" height="100">
<defs>
<svg id="rect" width="0" height="0">
<rect width="50" height="50" />
</svg>
</defs>
<use width="100" height="100" href="#rect" fill="green"></use>
<use x="0" y="50" width="100" height="100" href="#rect" fill="green"></use>
<use x="50" y="0" width="100" height="100" href="#rect" fill="green"></use>
<use x="50" y="50" width="100" height="100" href="#rect" fill="green"></use>
</svg>