mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-11 18:50:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb/HTML: Fix crash in window open steps on empty URL string

Browse source
This commit is contained in:
Shannon Booth 2024-12-11 10:38:16 +13:00 • committed by Tim Flynn
commit 4b069344e0
Notes: github-actions[bot] 2024-12-11 01:16:57 +00:00
3 changed files with 10 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibWeb/HTML/Window.cpp
View file

@ -221,8 +221,8 @@ WebIDL::ExceptionOr<Window::OpenedWindow> Window::window_open_steps_internal(Str
} }
// 9. Let noopener be the result of getting noopener for window open with sourceDocument, tokenizedFeatures, and urlRecord. // 9. Let noopener be the result of getting noopener for window open with sourceDocument, tokenizedFeatures, and urlRecord.
// FIXME: Is it safe to assume url_record has a value here? // FIXME: Spec bug: https://github.com/whatwg/html/issues/10844
auto no_opener = get_noopener_for_window_open(source_document, tokenized_features, *url_record); auto no_opener = get_noopener_for_window_open(source_document, tokenized_features, url_record.has_value() ? *url_record : URL::URL("about:blank"));
// 10. Remove tokenizedFeatures["noopener"] and tokenizedFeatures["noreferrer"]. // 10. Remove tokenizedFeatures["noopener"] and tokenizedFeatures["noreferrer"].
tokenized_features.remove("noopener"sv); tokenized_features.remove("noopener"sv);

1
Tests/LibWeb/Text/expected/HTML/Window-open-empty-string.txt Normal file
View file

@ -0,0 +1 @@
PASS! (Didn't crash)

7
Tests/LibWeb/Text/input/HTML/Window-open-empty-string.html Normal file
View file

@ -0,0 +1,7 @@
<script src="../include.js"></script>
<script>
test(() => {
window.open();
println("PASS! (Didn't crash)");
})
</script>