mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-05 23:59:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Cancel previous animation if new animation-name is "none"
Some checks are pending
CI / Lagom (arm64, Sanitizer_CI, false, macOS, macos-15, Clang) (push) Waiting to run
Details
CI / Lagom (x86_64, Fuzzers_CI, false, Linux, blacksmith-16vcpu-ubuntu-2404, Clang) (push) Waiting to run
Details
CI / Lagom (x86_64, Sanitizer_CI, false, Linux, blacksmith-16vcpu-ubuntu-2404, GNU) (push) Waiting to run
Details
CI / Lagom (x86_64, Sanitizer_CI, true, Linux, blacksmith-16vcpu-ubuntu-2404, Clang) (push) Waiting to run
Details
Package the js repl as a binary artifact / build-and-package (arm64, macOS, macOS-arm64, macos-15) (push) Waiting to run
Details
Package the js repl as a binary artifact / build-and-package (x86_64, Linux, Linux-x86_64, blacksmith-8vcpu-ubuntu-2404) (push) Waiting to run
Details
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Details
Lint Code / lint (push) Waiting to run
Details
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Details
Push notes / build (push) Waiting to run
Details

Browse source 
"none" value should be interpreted as "no animation" to trigger the path
that cancels previous animation if it exists.
This commit is contained in:
Aliaksandr Kalenik 2025-05-27 17:09:39 +02:00 • committed by Alexander Kalenik
commit 4b4d960cba
Notes: github-actions[bot] 2025-06-01 03:03:12 +00:00
3 changed files with 42 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/CSS/StyleComputer.cpp
View file

@ -2678,6 +2678,8 @@ GC::Ref<ComputedProperties> StyleComputer::compute_properties(DOM::Element& elem
auto const animation_name = computed_style->maybe_null_property(PropertyID::AnimationName); auto const animation_name = computed_style->maybe_null_property(PropertyID::AnimationName);
if (!animation_name) if (!animation_name)
return OptionalNone {}; return OptionalNone {};
if (animation_name->is_keyword() && animation_name->to_keyword() == Keyword::None)
return OptionalNone {};
if (animation_name->is_string()) if (animation_name->is_string())
return animation_name->as_string().string_value().to_string(); return animation_name->as_string().string_value().to_string();
return animation_name->to_string(SerializationMode::Normal); return animation_name->to_string(SerializationMode::Normal);

1
Tests/LibWeb/Text/expected/WebAnimations/cancel-animation.txt Normal file
View file

@ -0,0 +1 @@
Animation cancelled

39
Tests/LibWeb/Text/input/WebAnimations/cancel-animation.html Normal file
View file

@ -0,0 +1,39 @@
<!DOCTYPE html>
<html>
<body>
<div id="box"></div>
<style>
#box {
width: 100px;
height: 100px;
background: #000;
margin: 200px;
}
@keyframes enlarge {
from {
transform: scale(1);
}
to {
transform: scale(5);
}
}
</style>
</body>
<script src="../include.js"></script>
<script>
asyncTest(done => {
const box = document.getElementById("box");
box.addEventListener("animationcancel", () => {
println("Animation cancelled");
done();
});
box.addEventListener("animationstart", () => {
requestAnimationFrame(() => (box.style.animation = "none"));
});
box.style.animation = "enlarge 2s forwards";
});
</script>
</html>