mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-20 03:25:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Initialize AnalyserNode previous block at construction time

Browse source
This commit is contained in:
Tim Ledbetter 2025-02-13 18:32:30 +00:00 • committed by Luke Wilde
parent c9cd795257
commit 4bb22c52d1
Notes: github-actions[bot] 2025-02-13 20:32:32 +00:00
2 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibWeb/WebAudio/AnalyserNode.cpp
View file

@ -259,7 +259,7 @@ WebIDL::ExceptionOr<void> AnalyserNode::get_byte_time_domain_data(GC::Root<WebID
// https://webaudio.github.io/web-audio-api/#dom-analysernode-fftsize
WebIDL::ExceptionOr<void> AnalyserNode::set_fft_size(unsigned long fft_size)
{
if (fft_size < 32 || fft_size > 32768 || (fft_size & (fft_size - 1)) != 0)
if (fft_size < 32 || fft_size > 32768 || !is_power_of_two(fft_size))
return WebIDL::IndexSizeError::create(realm(), "Analyser node fftSize not a power of 2 between 32 and 32768"_string);
// reset previous block to 0s
@ -304,9 +304,6 @@ WebIDL::ExceptionOr<void> AnalyserNode::set_smoothing_time_constant(double smoot
WebIDL::ExceptionOr<GC::Ref<AnalyserNode>> AnalyserNode::construct_impl(JS::Realm& realm, GC::Ref<BaseAudioContext> context, AnalyserOptions const& options)
{
if (options.fft_size < 32 || options.fft_size > 32768 || !is_power_of_two(options.fft_size))
return WebIDL::IndexSizeError::create(realm, "Analyser node fftSize not a power of 2 between 32 and 32768"_string);
if (options.min_decibels >= options.max_decibels)
return WebIDL::IndexSizeError::create(realm, "Analyser node minDecibels greater than maxDecibels"_string);
@ -317,6 +314,7 @@ WebIDL::ExceptionOr<GC::Ref<AnalyserNode>> AnalyserNode::construct_impl(JS::Real
// MUST initialize the AudioNode this, with context and options as arguments.
auto node = realm.create<AnalyserNode>(realm, context, options);
TRY(node->set_fft_size(options.fft_size));
// Default options for channel count and interpretation
// https://webaudio.github.io/web-audio-api/#AnalyserNode

7
Tests/LibWeb/Crash/WebAudio/AnalyserNode-previous-block-initialization.html Normal file
View file

@ -0,0 +1,7 @@
<!DOCTYPE html>
<script>
const context = new OfflineAudioContext(1, 1, 44100)
const analyser = context.createAnalyser()
const dataArray = new Float32Array(analyser.frequencyBinCount)
analyser.getFloatFrequencyData(dataArray);
</script>