mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-05-03 17:58:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibJS: Only "var" declarations go in the global object at program level

Browse source 
"let" and "const" go in the lexical environment.

This fixes one part of #4001 (Lexically declared variables are mixed up
with global object properties)
This commit is contained in:
Andreas Kling 2021-06-09 23:21:42 +02:00
parent d5fa0ea60f
commit 4bc98fd39f
Notes: sideshowbarker 2024-07-18 12:30:37 +09:00
2 changed files with 24 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibJS/Interpreter.cpp
View file

@ -94,9 +94,11 @@ void Interpreter::enter_scope(const ScopeNode& scope_node, ScopeType scope_type,
HashMap<FlyString, Variable> scope_variables_with_declaration_kind;
scope_variables_with_declaration_kind.ensure_capacity(16);
bool is_program_node = is<Program>(scope_node);
for (auto& declaration : scope_node.variables()) {
for (auto& declarator : declaration.declarations()) {
if (is<Program>(scope_node)) {
if (is_program_node && declaration.declaration_kind() == DeclarationKind::Var) {
declarator.target().visit(
[&](const NonnullRefPtr<Identifier>& id) {
global_object.put(id->string(), js_undefined());