mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-05 07:41:01 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/HTML: Use a helper for converting 'time' value to string

Browse source 
This will make it trivial to implement valueAsNumber for 'time' input
type.
This commit is contained in:
Shannon Booth 2025-03-06 15:33:19 +13:00 • committed by Tim Flynn
commit 4bd4d777eb
Notes: github-actions[bot] 2025-03-06 14:02:20 +00:00
1 changed files with 16 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

24
Libraries/LibWeb/HTML/HTMLInputElement.cpp
View file

@ -2228,6 +2228,21 @@ static String convert_number_to_date_string(double input)
return MUST(date.to_string("%Y-%m-%d"sv, Core::DateTime::LocalTime::No)); return MUST(date.to_string("%Y-%m-%d"sv, Core::DateTime::LocalTime::No));
} }
// https://html.spec.whatwg.org/multipage/input.html#time-state-(type=time):concept-input-value-number-string
static String convert_number_to_time_string(double input)
{
// The algorithm to convert a number to a string, given a number input, is as follows: Return a valid time
// string that represents the time that is input milliseconds after midnight on a day with no time changes.
auto seconds = JS::sec_from_time(input);
auto milliseconds = JS::ms_from_time(input);
if (seconds > 0) {
if (milliseconds > 0)
return MUST(String::formatted("{:02d}:{:02d}:{:02d}.{:3d}", JS::hour_from_time(input), JS::min_from_time(input), seconds, milliseconds));
return MUST(String::formatted("{:02d}:{:02d}:{:02d}", JS::hour_from_time(input), JS::min_from_time(input), seconds));
}
return MUST(String::formatted("{:02d}:{:02d}", JS::hour_from_time(input), JS::min_from_time(input)));
}
// https://html.spec.whatwg.org/multipage/input.html#concept-input-value-string-number // https://html.spec.whatwg.org/multipage/input.html#concept-input-value-string-number
String HTMLInputElement::convert_number_to_string(double input) const String HTMLInputElement::convert_number_to_string(double input) const
{ {
@ -2296,14 +2311,7 @@ String HTMLInputElement::covert_date_to_string(GC::Ref<JS::Date> input) const
if (type_state() == TypeAttributeState::Time) { if (type_state() == TypeAttributeState::Time) {
// Return a valid time string that represents the UTC time component that is represented by input. // Return a valid time string that represents the UTC time component that is represented by input.
// https://html.spec.whatwg.org/multipage/common-microsyntaxes.html#valid-time-string // https://html.spec.whatwg.org/multipage/common-microsyntaxes.html#valid-time-string
auto seconds = JS::sec_from_time(input->date_value()); return convert_number_to_time_string(input->date_value());
auto milliseconds = JS::ms_from_time(input->date_value());
if (seconds > 0) {
if (milliseconds > 0)
return MUST(String::formatted("{:02d}:{:02d}:{:02d}.{:3d}", JS::hour_from_time(input->date_value()), JS::min_from_time(input->date_value()), seconds, milliseconds));
return MUST(String::formatted("{:02d}:{:02d}:{:02d}", JS::hour_from_time(input->date_value()), JS::min_from_time(input->date_value()), seconds));
}
return MUST(String::formatted("{:02d}:{:02d}", JS::hour_from_time(input->date_value()), JS::min_from_time(input->date_value())));
} }
dbgln("HTMLInputElement::covert_date_to_string() not implemented for input type {}", type()); dbgln("HTMLInputElement::covert_date_to_string() not implemented for input type {}", type());