mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-04 16:46:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Allocate dataset lazily for HTML/SVG/MathML elements

Browse source 
Most elements never need a dataset object, so we can avoid creating lots
of objects by making them lazy.
This commit is contained in:
Andreas Kling 2024-04-24 14:56:26 +02:00
commit 4c921e17b7
Notes: sideshowbarker 2024-07-17 06:51:10 +09:00
6 changed files with 23 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Userland/Libraries/LibWeb/SVG/SVGElement.cpp
View file

@ -25,8 +25,6 @@ void SVGElement::initialize(JS::Realm& realm)
{
Base::initialize(realm);
WEB_SET_PROTOTYPE_FOR_INTERFACE(SVGElement);
m_dataset = HTML::DOMStringMap::create(*this);
}
void SVGElement::visit_edges(Cell::Visitor& visitor)
@ -35,6 +33,13 @@ void SVGElement::visit_edges(Cell::Visitor& visitor)
visitor.visit(m_dataset);
}
JS::NonnullGCPtr<HTML::DOMStringMap> SVGElement::dataset()
{
if (!m_dataset)
m_dataset = HTML::DOMStringMap::create(*this);
return *m_dataset;
}
void SVGElement::attribute_changed(FlyString const& name, Optional<String> const& value)
{
Base::attribute_changed(name, value);

3
Userland/Libraries/LibWeb/SVG/SVGElement.h
View file

@ -23,8 +23,7 @@ public:
virtual void inserted() override;
virtual void removed_from(Node*) override;
HTML::DOMStringMap* dataset() { return m_dataset.ptr(); }
HTML::DOMStringMap const* dataset() const { return m_dataset.ptr(); }
[[nodiscard]] JS::NonnullGCPtr<HTML::DOMStringMap> dataset();
void focus();
void blur();