mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-05-02 01:08:48 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Don't take rendering task from queue while running rendering

Browse source 
If event loop is already executing rendering task, we should not start
the next rendering task until the current one is finished.

Fixes https://github.com/LadybirdBrowser/ladybird/issues/3717
This commit is contained in:
Aliaksandr Kalenik 2025-02-27 15:41:15 +01:00 • committed by Alexander Kalenik
parent b8af3fccf6
commit 4ca330adef
Notes: github-actions[bot] 2025-02-27 16:34:31 +00:00
3 changed files with 11 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Libraries/LibWeb/HTML/EventLoop/EventLoop.cpp
View file

@ -312,10 +312,10 @@ void EventLoop::process_input_events() const
// https://html.spec.whatwg.org/multipage/webappapis.html#update-the-rendering
void EventLoop::update_the_rendering()
{
VERIFY(!m_is_running_rendering_task);
m_is_running_rendering_task = true;
VERIFY(!m_running_rendering_task);
m_running_rendering_task = true;
ScopeGuard const guard = [this] {
m_is_running_rendering_task = false;
m_running_rendering_task = false;
};
process_input_events();
@ -729,7 +729,7 @@ EventLoop::PauseHandle EventLoop::pause()
auto time_before_pause = HighResolutionTime::current_high_resolution_time(global);
// 3. If necessary, update the rendering or user interface of any Document or navigable to reflect the current state.
if (!m_is_running_rendering_task)
if (!m_running_rendering_task)
update_the_rendering();
// 4. Wait until the condition goal is met. While a user agent has a paused task, the corresponding event loop must