mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-21 16:58:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Don't crash when SVG viewbox has a width of 0

Browse source 
Previously, `SVGSVGBox` would have a natural aspect ratio of 0 if it
had a viewbox with zero width. This led to a division by zero, causing
a crash.

Found by Domato.
This commit is contained in:
Tim Ledbetter 2024-07-21 21:58:24 +01:00 • committed by Andreas Kling
commit 4cdafea363
Notes: github-actions[bot] 2024-07-22 07:14:21 +00:00
3 changed files with 14 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibWeb/Layout/SVGSVGBox.cpp
View file

@ -75,9 +75,10 @@ Optional<CSSPixelFraction> SVGSVGBox::calculate_intrinsic_aspect_ratio() const
auto const& viewbox = dom_node().view_box().value();
// 2. return viewbox.width / viewbox.height
auto viewbox_width = CSSPixels::nearest_value_for(viewbox.width);
auto viewbox_height = CSSPixels::nearest_value_for(viewbox.height);
if (viewbox_height != 0)
return CSSPixels::nearest_value_for(viewbox.width) / viewbox_height;
if (viewbox_width != 0 && viewbox_height != 0)
return viewbox_width / viewbox_height;
return {};
}