mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-21 03:55:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Optimize the case when invalidation set contains "whole subtree"

Browse source 
Instead of marking all nodes in the subtree for style recalculation,
including subtrees of subsequent siblings, we can fall back to the
default invalidation path, which is optimized to skip siblings
unaffected by sibling selectors.

Makes scrolling on https://frame.work/pl/en/about go a lot smoother.
This commit is contained in:
Aliaksandr Kalenik 2025-03-01 01:23:55 +01:00 • committed by Andreas Kling
parent b353211700
commit 4d1329e0ea
Notes: github-actions[bot] 2025-03-01 12:43:02 +00:00
1 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
Libraries/LibWeb/DOM/Node.cpp
View file

@ -467,7 +467,7 @@ void Node::invalidate_style(StyleInvalidationReason reason)
document().schedule_style_update();
}
void Node::invalidate_style(StyleInvalidationReason, Vector<CSS::InvalidationSet::Property> const& properties, StyleInvalidationOptions options)
void Node::invalidate_style(StyleInvalidationReason reason, Vector<CSS::InvalidationSet::Property> const& properties, StyleInvalidationOptions options)
{
if (is_character_data())
return;
@ -486,6 +486,11 @@ void Node::invalidate_style(StyleInvalidationReason, Vector<CSS::InvalidationSet
if (invalidation_set.is_empty())
return;
if (invalidation_set.needs_invalidate_whole_subtree()) {
invalidate_style(reason);
return;
}
if (invalidation_set.needs_invalidate_self()) {
set_needs_style_update(true);
}
@ -497,8 +502,10 @@ void Node::invalidate_style(StyleInvalidationReason, Vector<CSS::InvalidationSet
auto& element = static_cast<Element&>(node);
bool needs_style_recalculation = false;
if (invalidation_set.needs_invalidate_whole_subtree()) {
needs_style_recalculation = true;
} else if (element.includes_properties_from_invalidation_set(invalidation_set)) {
VERIFY_NOT_REACHED();
}
if (element.includes_properties_from_invalidation_set(invalidation_set)) {
needs_style_recalculation = true;
} else if (options.invalidate_elements_that_use_css_custom_properties && element.style_uses_css_custom_properties()) {
needs_style_recalculation = true;