LibJS: Ensure iterator parameter validation closes underlying iterator

This is a normative change in the ECMA-262 spec. See: 9552f29 f2bad00
Author: https://github.com/trflynn89 Commit: 4d70f6ce1c Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/4514
2025-08-01 21:59:07 +00:00 · 2025-04-28 19:03:05 -04:00 · 2025-04-28 19:03:05 -04:00 · 4d70f6ce1c · 2025-04-29 11:34:08 +00:00
commit 4d70f6ce1c
parent 908349f8fe
11 changed files with 408 additions and 144 deletions
--- a/Libraries/LibJS/Tests/builtins/Iterator/Iterator.prototype.drop.js
+++ b/Libraries/LibJS/Tests/builtins/Iterator/Iterator.prototype.drop.js
@ -5,6 +5,24 @@ describe("errors", () => {
        }).toThrowWithMessage(TypeError, "Cannot convert symbol to number");
    });

+    test("argument validation closes underlying iterator", () => {
+        let closed = false;
+        let iterator = {
+            __proto__: Iterator.prototype,
+
+            return() {
+                closed = true;
+                return {};
+            },
+        };
+
+        expect(() => {
+            iterator.drop(Symbol.hasInstance);
+        }).toThrowWithMessage(TypeError, "Cannot convert symbol to number");
+
+        expect(closed).toBeTrue();
+    });
+
    test("called with invalid numbers", () => {
        expect(() => {
            Iterator.prototype.drop(NaN);
--- a/Libraries/LibJS/Tests/builtins/Iterator/Iterator.prototype.every.js
+++ b/Libraries/LibJS/Tests/builtins/Iterator/Iterator.prototype.every.js
@ -5,6 +5,24 @@ describe("errors", () => {
        }).toThrowWithMessage(TypeError, "predicate is not a function");
    });

+    test("argument validation closes underlying iterator", () => {
+        let closed = false;
+        let iterator = {
+            __proto__: Iterator.prototype,
+
+            return() {
+                closed = true;
+                return {};
+            },
+        };
+
+        expect(() => {
+            iterator.every(Symbol.hasInstance);
+        }).toThrowWithMessage(TypeError, "predicate is not a function");
+
+        expect(closed).toBeTrue();
+    });
+
    test("iterator's next method throws", () => {
        function TestError() {}

--- a/Libraries/LibJS/Tests/builtins/Iterator/Iterator.prototype.filter.js
+++ b/Libraries/LibJS/Tests/builtins/Iterator/Iterator.prototype.filter.js
@ -5,6 +5,24 @@ describe("errors", () => {
        }).toThrowWithMessage(TypeError, "predicate is not a function");
    });

+    test("argument validation closes underlying iterator", () => {
+        let closed = false;
+        let iterator = {
+            __proto__: Iterator.prototype,
+
+            return() {
+                closed = true;
+                return {};
+            },
+        };
+
+        expect(() => {
+            iterator.filter(Symbol.hasInstance);
+        }).toThrowWithMessage(TypeError, "predicate is not a function");
+
+        expect(closed).toBeTrue();
+    });
+
    test("iterator's next method throws", () => {
        function TestError() {}

--- a/Libraries/LibJS/Tests/builtins/Iterator/Iterator.prototype.find.js
+++ b/Libraries/LibJS/Tests/builtins/Iterator/Iterator.prototype.find.js
@ -5,6 +5,24 @@ describe("errors", () => {
        }).toThrowWithMessage(TypeError, "predicate is not a function");
    });

+    test("argument validation closes underlying iterator", () => {
+        let closed = false;
+        let iterator = {
+            __proto__: Iterator.prototype,
+
+            return() {
+                closed = true;
+                return {};
+            },
+        };
+
+        expect(() => {
+            iterator.find(Symbol.hasInstance);
+        }).toThrowWithMessage(TypeError, "predicate is not a function");
+
+        expect(closed).toBeTrue();
+    });
+
    test("iterator's next method throws", () => {
        function TestError() {}

--- a/Libraries/LibJS/Tests/builtins/Iterator/Iterator.prototype.flatMap.js
+++ b/Libraries/LibJS/Tests/builtins/Iterator/Iterator.prototype.flatMap.js
@ -5,6 +5,24 @@ describe("errors", () => {
        }).toThrowWithMessage(TypeError, "mapper is not a function");
    });

+    test("argument validation closes underlying iterator", () => {
+        let closed = false;
+        let iterator = {
+            __proto__: Iterator.prototype,
+
+            return() {
+                closed = true;
+                return {};
+            },
+        };
+
+        expect(() => {
+            iterator.flatMap(Symbol.hasInstance);
+        }).toThrowWithMessage(TypeError, "mapper is not a function");
+
+        expect(closed).toBeTrue();
+    });
+
    test("iterator's next method throws", () => {
        function TestError() {}

--- a/Libraries/LibJS/Tests/builtins/Iterator/Iterator.prototype.forEach.js
+++ b/Libraries/LibJS/Tests/builtins/Iterator/Iterator.prototype.forEach.js
@ -2,7 +2,25 @@ describe("errors", () => {
    test("called with non-callable object", () => {
        expect(() => {
            Iterator.prototype.forEach(Symbol.hasInstance);
-        }).toThrowWithMessage(TypeError, "fn is not a function");
+        }).toThrowWithMessage(TypeError, "procedure is not a function");
+    });
+
+    test("argument validation closes underlying iterator", () => {
+        let closed = false;
+        let iterator = {
+            __proto__: Iterator.prototype,
+
+            return() {
+                closed = true;
+                return {};
+            },
+        };
+
+        expect(() => {
+            iterator.forEach(Symbol.hasInstance);
+        }).toThrowWithMessage(TypeError, "procedure is not a function");
+
+        expect(closed).toBeTrue();
    });

    test("iterator's next method throws", () => {
--- a/Libraries/LibJS/Tests/builtins/Iterator/Iterator.prototype.map.js
+++ b/Libraries/LibJS/Tests/builtins/Iterator/Iterator.prototype.map.js
@ -5,6 +5,24 @@ describe("errors", () => {
        }).toThrowWithMessage(TypeError, "mapper is not a function");
    });

+    test("argument validation closes underlying iterator", () => {
+        let closed = false;
+        let iterator = {
+            __proto__: Iterator.prototype,
+
+            return() {
+                closed = true;
+                return {};
+            },
+        };
+
+        expect(() => {
+            iterator.map(Symbol.hasInstance);
+        }).toThrowWithMessage(TypeError, "mapper is not a function");
+
+        expect(closed).toBeTrue();
+    });
+
    test("iterator's next method throws", () => {
        function TestError() {}

--- a/Libraries/LibJS/Tests/builtins/Iterator/Iterator.prototype.reduce.js
+++ b/Libraries/LibJS/Tests/builtins/Iterator/Iterator.prototype.reduce.js
@ -5,6 +5,24 @@ describe("errors", () => {
        }).toThrowWithMessage(TypeError, "reducer is not a function");
    });

+    test("argument validation closes underlying iterator", () => {
+        let closed = false;
+        let iterator = {
+            __proto__: Iterator.prototype,
+
+            return() {
+                closed = true;
+                return {};
+            },
+        };
+
+        expect(() => {
+            iterator.reduce(Symbol.hasInstance);
+        }).toThrowWithMessage(TypeError, "reducer is not a function");
+
+        expect(closed).toBeTrue();
+    });
+
    test("iterator's next method throws", () => {
        function TestError() {}

--- a/Libraries/LibJS/Tests/builtins/Iterator/Iterator.prototype.some.js
+++ b/Libraries/LibJS/Tests/builtins/Iterator/Iterator.prototype.some.js
@ -5,6 +5,24 @@ describe("errors", () => {
        }).toThrowWithMessage(TypeError, "predicate is not a function");
    });

+    test("argument validation closes underlying iterator", () => {
+        let closed = false;
+        let iterator = {
+            __proto__: Iterator.prototype,
+
+            return() {
+                closed = true;
+                return {};
+            },
+        };
+
+        expect(() => {
+            iterator.some(Symbol.hasInstance);
+        }).toThrowWithMessage(TypeError, "predicate is not a function");
+
+        expect(closed).toBeTrue();
+    });
+
    test("iterator's next method throws", () => {
        function TestError() {}

--- a/Libraries/LibJS/Tests/builtins/Iterator/Iterator.prototype.take.js
+++ b/Libraries/LibJS/Tests/builtins/Iterator/Iterator.prototype.take.js
@ -5,6 +5,24 @@ describe("errors", () => {
        }).toThrowWithMessage(TypeError, "Cannot convert symbol to number");
    });

+    test("argument validation closes underlying iterator", () => {
+        let closed = false;
+        let iterator = {
+            __proto__: Iterator.prototype,
+
+            return() {
+                closed = true;
+                return {};
+            },
+        };
+
+        expect(() => {
+            iterator.take(Symbol.hasInstance);
+        }).toThrowWithMessage(TypeError, "Cannot convert symbol to number");
+
+        expect(closed).toBeTrue();
+    });
+
    test("called with invalid numbers", () => {
        expect(() => {
            Iterator.prototype.take(NaN);