LibJS: Convert to_string() to ThrowCompletionOr

Also update get_function_name() to use ThrowCompletionOr, but this is not a standard AO and should be refactored out of existence eventually.
Author: https://github.com/linusg Commit: 4d8912a92b Pull-request: https://github.com/SerenityOS/serenity/pull/10452 Reviewed-by: https://github.com/IdanHo ✅
2025-08-24 11:21:34 +00:00 · 2021-10-12 17:49:01 +01:00 · 2021-10-12 17:49:01 +01:00 · 4d8912a92b · 2024-07-18 02:47:45 +09:00
commit 4d8912a92b
parent 5d38cf4973
48 changed files with 171 additions and 415 deletions
--- a/Userland/Applications/Spreadsheet/SpreadsheetModel.cpp
+++ b/Userland/Applications/Spreadsheet/SpreadsheetModel.cpp
@ -40,7 +40,7 @@ GUI::Variant SheetModel::data(const GUI::ModelIndex& index, GUI::ModelRole role)
                        return builder.to_string();
                    }
                }
-                auto error = value.to_string(cell->sheet().global_object());
+                auto error = value.to_string_without_side_effects();
                // This is annoying, but whatever.
                cell->sheet().interpreter().vm().clear_exception();