LibJS: Tweak AssignmentOp names

This commit is contained in:
Andreas Kling 2020-03-12 13:54:56 +01:00
parent 4781e3fb72
commit 4dc1d6654f
Notes: sideshowbarker 2024-07-19 08:21:00 +09:00
3 changed files with 20 additions and 20 deletions

View file

@ -419,22 +419,22 @@ Value AssignmentExpression::execute(Interpreter& interpreter) const
auto rhs_result = m_rhs->execute(interpreter);
switch (m_op) {
case AssignmentOp::Assign:
case AssignmentOp::Assignment:
interpreter.set_variable(name, rhs_result);
break;
case AssignmentOp::PlusEquals:
case AssignmentOp::AdditionAssignment:
rhs_result = add(m_lhs->execute(interpreter), rhs_result);
interpreter.set_variable(name, rhs_result);
break;
case AssignmentOp::MinusEquals:
case AssignmentOp::SubtractionAssignment:
rhs_result = sub(m_lhs->execute(interpreter), rhs_result);
interpreter.set_variable(name, rhs_result);
break;
case AssignmentOp::AsteriskEquals:
case AssignmentOp::MultiplicationAssignment:
rhs_result = mul(m_lhs->execute(interpreter), rhs_result);
interpreter.set_variable(name, rhs_result);
break;
case AssignmentOp::SlashEquals:
case AssignmentOp::DivisionAssignment:
rhs_result = div(m_lhs->execute(interpreter), rhs_result);
interpreter.set_variable(name, rhs_result);
break;
@ -446,19 +446,19 @@ void AssignmentExpression::dump(int indent) const
{
const char* op_string = nullptr;
switch (m_op) {
case AssignmentOp::Assign:
case AssignmentOp::Assignment:
op_string = "=";
break;
case AssignmentOp::PlusEquals:
case AssignmentOp::AdditionAssignment:
op_string = "+=";
break;
case AssignmentOp::MinusEquals:
case AssignmentOp::SubtractionAssignment:
op_string = "-=";
break;
case AssignmentOp::AsteriskEquals:
case AssignmentOp::MultiplicationAssignment:
op_string = "*=";
break;
case AssignmentOp::SlashEquals:
case AssignmentOp::DivisionAssignment:
op_string = "/=";
break;
}

View file

@ -417,11 +417,11 @@ private:
};
enum class AssignmentOp {
Assign,
PlusEquals,
MinusEquals,
AsteriskEquals,
SlashEquals,
Assignment,
AdditionAssignment,
SubtractionAssignment,
MultiplicationAssignment,
DivisionAssignment,
};
class AssignmentExpression : public Expression {

View file

@ -128,25 +128,25 @@ NonnullOwnPtr<Expression> Parser::parse_secondary_expression(NonnullOwnPtr<Expre
return make<BinaryExpression>(BinaryOp::Plus, move(lhs), parse_expression());
case TokenType::PlusEquals:
consume();
return make<AssignmentExpression>(AssignmentOp::PlusEquals, move(lhs), parse_expression());
return make<AssignmentExpression>(AssignmentOp::AdditionAssignment, move(lhs), parse_expression());
case TokenType::Minus:
consume();
return make<BinaryExpression>(BinaryOp::Minus, move(lhs), parse_expression());
case TokenType::MinusEquals:
consume();
return make<AssignmentExpression>(AssignmentOp::MinusEquals, move(lhs), parse_expression());
return make<AssignmentExpression>(AssignmentOp::SubtractionAssignment, move(lhs), parse_expression());
case TokenType::Asterisk:
consume();
return make<BinaryExpression>(BinaryOp::Asterisk, move(lhs), parse_expression());
case TokenType::AsteriskEquals:
consume();
return make<AssignmentExpression>(AssignmentOp::AsteriskEquals, move(lhs), parse_expression());
return make<AssignmentExpression>(AssignmentOp::MultiplicationAssignment, move(lhs), parse_expression());
case TokenType::Slash:
consume();
return make<BinaryExpression>(BinaryOp::Slash, move(lhs), parse_expression());
case TokenType::SlashEquals:
consume();
return make<AssignmentExpression>(AssignmentOp::SlashEquals, move(lhs), parse_expression());
return make<AssignmentExpression>(AssignmentOp::DivisionAssignment, move(lhs), parse_expression());
case TokenType::GreaterThan:
consume();
return make<BinaryExpression>(BinaryOp::GreaterThan, move(lhs), parse_expression());
@ -169,7 +169,7 @@ NonnullOwnPtr<Expression> Parser::parse_secondary_expression(NonnullOwnPtr<Expre
return parse_call_expression(move(lhs));
case TokenType::Equals:
consume();
return make<AssignmentExpression>(AssignmentOp::Assign, move(lhs), parse_expression());
return make<AssignmentExpression>(AssignmentOp::Assignment, move(lhs), parse_expression());
case TokenType::Period:
consume();
return make<MemberExpression>(move(lhs), parse_expression());