mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-24 18:02:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Add oncontrollerchange to ServiceWorkerContainer

Browse source
This commit is contained in:
Andrew Kaster 2024-09-04 15:16:30 -06:00 • committed by Andreas Kling
parent 2667726b74
commit 4df280689b
Notes: github-actions[bot] 2024-09-07 09:40:08 +00:00
4 changed files with 25 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Userland/Libraries/LibWeb/HTML/EventNames.h
View file

@ -34,6 +34,7 @@ namespace Web::HTML::EventNames {
__ENUMERATE_HTML_EVENT(close) \ __ENUMERATE_HTML_EVENT(close) \
__ENUMERATE_HTML_EVENT(complete) \ __ENUMERATE_HTML_EVENT(complete) \
__ENUMERATE_HTML_EVENT(connect) \ __ENUMERATE_HTML_EVENT(connect) \
__ENUMERATE_HTML_EVENT(controllerchange) \
__ENUMERATE_HTML_EVENT(contextmenu) \ __ENUMERATE_HTML_EVENT(contextmenu) \
__ENUMERATE_HTML_EVENT(copy) \ __ENUMERATE_HTML_EVENT(copy) \
__ENUMERATE_HTML_EVENT(cuechange) \ __ENUMERATE_HTML_EVENT(cuechange) \

35
Userland/Libraries/LibWeb/HTML/ServiceWorkerContainer.cpp
View file

@ -31,28 +31,17 @@ JS::NonnullGCPtr<ServiceWorkerContainer> ServiceWorkerContainer::create(JS::Real
return realm.heap().allocate<ServiceWorkerContainer>(realm, realm); return realm.heap().allocate<ServiceWorkerContainer>(realm, realm);
} }
// https://w3c.github.io/ServiceWorker/#dom-serviceworkercontainer-onmessage #undef __ENUMERATE
WebIDL::CallbackType* ServiceWorkerContainer::onmessage() #define __ENUMERATE(attribute_name, event_name) \
{ void ServiceWorkerContainer::set_##attribute_name(WebIDL::CallbackType* value) \
return event_handler_attribute(HTML::EventNames::message); { \
} set_event_handler_attribute(event_name, move(value)); \
} \
// https://w3c.github.io/ServiceWorker/#dom-serviceworkercontainer-onmessage WebIDL::CallbackType* ServiceWorkerContainer::attribute_name() \
void ServiceWorkerContainer::set_onmessage(WebIDL::CallbackType* event_handler) { \
{ return event_handler_attribute(event_name); \
set_event_handler_attribute(HTML::EventNames::message, event_handler); }
} ENUMERATE_SERVICE_WORKER_CONTAINER_EVENT_HANDLERS(__ENUMERATE)
#undef __ENUMERATE
// https://w3c.github.io/ServiceWorker/#dom-serviceworkercontainer-onmessageerror
WebIDL::CallbackType* ServiceWorkerContainer::onmessageerror()
{
return event_handler_attribute(HTML::EventNames::messageerror);
}
// https://w3c.github.io/ServiceWorker/#dom-serviceworkercontainer-onmessageerror
void ServiceWorkerContainer::set_onmessageerror(WebIDL::CallbackType* event_handler)
{
set_event_handler_attribute(HTML::EventNames::messageerror, event_handler);
}
} }

15
Userland/Libraries/LibWeb/HTML/ServiceWorkerContainer.h
View file

@ -9,6 +9,11 @@
#include <LibWeb/DOM/EventTarget.h> #include <LibWeb/DOM/EventTarget.h>
#define ENUMERATE_SERVICE_WORKER_CONTAINER_EVENT_HANDLERS(E) \
E(oncontrollerchange, HTML::EventNames::controllerchange) \
E(onmessage, HTML::EventNames::message) \
E(onmessageerror, HTML::EventNames::messageerror)
namespace Web::HTML { namespace Web::HTML {
class ServiceWorkerContainer : public DOM::EventTarget { class ServiceWorkerContainer : public DOM::EventTarget {
@ -19,10 +24,12 @@ public:
[[nodiscard]] static JS::NonnullGCPtr<ServiceWorkerContainer> create(JS::Realm& realm); [[nodiscard]] static JS::NonnullGCPtr<ServiceWorkerContainer> create(JS::Realm& realm);
virtual ~ServiceWorkerContainer() override = default; virtual ~ServiceWorkerContainer() override = default;
WebIDL::CallbackType* onmessage(); #undef __ENUMERATE
void set_onmessage(WebIDL::CallbackType*); #define __ENUMERATE(attribute_name, event_name) \
WebIDL::CallbackType* onmessageerror(); void set_##attribute_name(WebIDL::CallbackType*); \
void set_onmessageerror(WebIDL::CallbackType*); WebIDL::CallbackType* attribute_name();
ENUMERATE_SERVICE_WORKER_CONTAINER_EVENT_HANDLERS(__ENUMERATE)
#undef __ENUMERATE
private: private:
explicit ServiceWorkerContainer(JS::Realm&); explicit ServiceWorkerContainer(JS::Realm&);

2
Userland/Libraries/LibWeb/HTML/ServiceWorkerContainer.idl
View file

@ -17,7 +17,7 @@ interface ServiceWorkerContainer : EventTarget {
[FIXME] undefined startMessages(); [FIXME] undefined startMessages();
// events // events
[FIXME] attribute EventHandler oncontrollerchange; attribute EventHandler oncontrollerchange;
attribute EventHandler onmessage; // event.source of message events is ServiceWorker object attribute EventHandler onmessage; // event.source of message events is ServiceWorker object
attribute EventHandler onmessageerror; attribute EventHandler onmessageerror;
}; };