mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-03 15:41:57 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb/CSS: Use CalcSV's context to determine what percentages are

Browse source 
This lets us implement the `matches_number()` and `matches_dimension()`
methods of `CSSNumericType` to spec, instead of being an ad-hoc hack.
This commit is contained in:
Sam Atkins 2025-01-09 17:23:20 +00:00
parent 6f60c258ce
commit 4e1aa96dce
Notes: github-actions[bot] 2025-01-13 11:00:10 +00:00
5 changed files with 98 additions and 79 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateCSSMathFunctions.cpp
View file

@ -53,23 +53,23 @@ String generate_calculation_type_check(StringView calculation_variable_name, Str
first_type_check = false;
if (allowed_type_name == "<angle>"sv) {
builder.appendff("{}.{}", calculation_variable_name, "matches_angle()"sv);
builder.appendff("{}.{}", calculation_variable_name, "matches_angle(percentages_resolve_as)"sv);
} else if (allowed_type_name == "<dimension>"sv) {
builder.appendff("{}.{}", calculation_variable_name, "matches_dimension()"sv);
} else if (allowed_type_name == "<flex>"sv) {
builder.appendff("{}.{}", calculation_variable_name, "matches_flex()"sv);
builder.appendff("{}.{}", calculation_variable_name, "matches_flex(percentages_resolve_as)"sv);
} else if (allowed_type_name == "<frequency>"sv) {
builder.appendff("{}.{}", calculation_variable_name, "matches_frequency()"sv);
builder.appendff("{}.{}", calculation_variable_name, "matches_frequency(percentages_resolve_as)"sv);
} else if (allowed_type_name == "<length>"sv) {
builder.appendff("{}.{}", calculation_variable_name, "matches_length()"sv);
builder.appendff("{}.{}", calculation_variable_name, "matches_length(percentages_resolve_as)"sv);
} else if (allowed_type_name == "<number>"sv) {
builder.appendff("{}.{}", calculation_variable_name, "matches_number()"sv);
builder.appendff("{}.{}", calculation_variable_name, "matches_number(percentages_resolve_as)"sv);
} else if (allowed_type_name == "<percentage>"sv) {
builder.appendff("{}.{}", calculation_variable_name, "matches_percentage()"sv);
} else if (allowed_type_name == "<resolution>"sv) {
builder.appendff("{}.{}", calculation_variable_name, "matches_resolution()"sv);
builder.appendff("{}.{}", calculation_variable_name, "matches_resolution(percentages_resolve_as)"sv);
} else if (allowed_type_name == "<time>"sv) {
builder.appendff("{}.{}", calculation_variable_name, "matches_time()"sv);
builder.appendff("{}.{}", calculation_variable_name, "matches_time(percentages_resolve_as)"sv);
} else {
dbgln("I don't know what '{}' is!", allowed_type_name);
VERIFY_NOT_REACHED();
@ -120,6 +120,7 @@ OwnPtr<CalculationNode> Parser::parse_math_function(Function const& function, Ca
{
TokenStream stream { function.value };
auto arguments = parse_a_comma_separated_list_of_component_values(stream);
auto const& percentages_resolve_as = context.percentages_resolve_as;
)~~~");
functions_data.for_each_member([&](auto& name, JsonValue const& value) -> void {