Services: Fix visibility of Object-derivative constructors

Derivatives of Core::Object should be constructed through ClassName::construct(), to avoid handling ref-counted objects with refcount zero. Fixing the visibility means that misuses like this are more difficult.
Author: https://github.com/BenWiederhake Commit: 4e55d649d7 Pull-request: https://github.com/SerenityOS/serenity/pull/10745 Reviewed-by: https://github.com/PeterBindels-TomTom Reviewed-by: https://github.com/sin-ack ✅
2025-08-01 05:39:11 +00:00 · 2021-10-31 23:38:04 +01:00 · 2021-10-31 23:38:04 +01:00 · 4e55d649d7 · 2024-07-18 01:32:59 +09:00
commit 4e55d649d7
parent b3e9a4e603
19 changed files with 45 additions and 26 deletions
--- a/Userland/Services/ImageDecoder/ClientConnection.h
+++ b/Userland/Services/ImageDecoder/ClientConnection.h
@ -20,12 +20,13 @@ class ClientConnection final
    C_OBJECT(ClientConnection);

 public:
-    explicit ClientConnection(NonnullRefPtr<Core::LocalSocket>, int client_id);
    ~ClientConnection() override;

    virtual void die() override;

 private:
+    explicit ClientConnection(NonnullRefPtr<Core::LocalSocket>, int client_id);
+
    virtual Messages::ImageDecoderServer::DecodeImageResponse decode_image(Core::AnonymousBuffer const&) override;
 };