mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-09 01:29:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Return empty string if image element currentSrc URL is invalid

Browse source
This commit is contained in:
Tim Ledbetter 2024-08-14 23:52:11 +01:00 • committed by Andreas Kling
commit 4f7a4d9c57
Notes: github-actions[bot] 2024-08-15 07:45:34 +00:00
3 changed files with 19 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Tests/LibWeb/Text/expected/HTML/invalid-url-attribute-values.txt Normal file
View file

@ -0,0 +1 @@
img.currentSrc default value: ''

14
Tests/LibWeb/Text/input/HTML/invalid-url-attribute-values.html Normal file
View file

@ -0,0 +1,14 @@
<!DOCTYPE html>
<script src="../include.js"></script>
<script>
test(() => {
const elementList = [
{ "img": "currentSrc" },
];
for (const elementDescriptor of elementList) {
[elementName, propertyName] = Object.entries(elementDescriptor)[0];
const element = document.createElement(elementName);
println(`${elementName}.${propertyName} default value: '${element[propertyName]}'`);
}
});
</script>

5
Userland/Libraries/LibWeb/HTML/HTMLImageElement.cpp
View file

@ -275,7 +275,10 @@ bool HTMLImageElement::complete() const
String HTMLImageElement::current_src() const String HTMLImageElement::current_src() const
{ {
// The currentSrc IDL attribute must return the img element's current request's current URL. // The currentSrc IDL attribute must return the img element's current request's current URL.
return MUST(m_current_request->current_url().to_string()); auto current_url = m_current_request->current_url();
if (!current_url.is_valid())
return {};
return MUST(current_url.to_string());
} }
// https://html.spec.whatwg.org/multipage/embedded-content.html#dom-img-decode // https://html.spec.whatwg.org/multipage/embedded-content.html#dom-img-decode