mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-20 19:45:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Return a better error message for invalid byte strings

Browse source 
We are currently returning LibJS's invalid code point message, but not
formatting it with the bad value. So we get something like:

    Unhandled JavaScript exception: [TypeError] Invalid code point {},
    must be an integer no less than 0 and no greater than 0x10FFFF

So not only is the error unformatted, but it's inaccurate; in this case,
the byte cannot be larger than 255.
This commit is contained in:
Timothy Flynn 2024-12-10 11:13:40 -05:00 • committed by Tim Flynn
parent a64432ec13
commit 520bf6c9be
Notes: github-actions[bot] 2024-12-10 18:31:16 +00:00
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Libraries/LibWeb/WebIDL/AbstractOperations.cpp
View file

@ -7,6 +7,7 @@
*/
#include <AK/ByteBuffer.h>
#include <AK/Enumerate.h>
#include <AK/Math.h>
#include <AK/NumericLimits.h>
#include <LibJS/Runtime/AbstractOperations.h>
@ -232,9 +233,9 @@ JS::ThrowCompletionOr<String> to_byte_string(JS::VM& vm, JS::Value value)
auto x = TRY(value.to_string(vm));
// 2. If the value of any element of x is greater than 255, then throw a TypeError.
for (auto character : x.code_points()) {
for (auto [i, character] : enumerate(x.code_points())) {
if (character > 0xFF)
return vm.throw_completion<JS::TypeError>(JS::ErrorType::InvalidCodePoint);
return vm.throw_completion<JS::TypeError>(MUST(String::formatted("Invalid byte 0x{:X} at index {}, must be an integer no less than 0 and no greater than 0xFF", character, x.code_points().byte_offset_of(i))));
}
// 3. Return an IDL ByteString value whose length is the length of x, and where the value of each element is the value of the corresponding element of x.