mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-30 04:39:06 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibRegex: Don't use Optional<T> inside regex::Match

Browse source 
This prevented Match from being trivially copyable, which we want it to
be for fast Vector copying.
This commit is contained in:
Andreas Kling 2025-04-14 15:33:33 +02:00 • committed by Andreas Kling
commit 5308d77600
Notes: github-actions[bot] 2025-04-14 15:41:20 +00:00
3 changed files with 11 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibJS/Runtime/RegExpPrototype.cpp
View file

@ -328,9 +328,9 @@ static ThrowCompletionOr<Value> regexp_builtin_exec(VM& vm, RegExpObject& regexp
MUST(array->create_data_property_or_throw(i, captured_value));
// e. If the ith capture of R was defined with a GroupName, then
if (capture.capture_group_name.has_value()) {
if (capture.capture_group_name >= 0) {
// i. Let s be the CapturingGroupName of the corresponding RegExpIdentifierName.
auto group_name = regex.parser_result.bytecode.get_string(capture.capture_group_name.release_value());
auto group_name = regex.parser_result.bytecode.get_string(capture.capture_group_name);
// ii. Perform ! CreateDataPropertyOrThrow(groups, s, capturedValue).
MUST(groups_object->create_data_property_or_throw(group_name, captured_value));