mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 12:19:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Don't crash when setting offscreen canvas size to 0

Browse source 
Previously, this would crash because `Gfx::Bitmap` can't have a zero
size.
This commit is contained in:
Tim Ledbetter 2025-07-01 01:19:08 +01:00 • committed by Sam Atkins
commit 5413716802
Notes: github-actions[bot] 2025-07-04 15:11:48 +00:00
5 changed files with 78 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Libraries/LibWeb/HTML/OffscreenCanvas.h
View file

@ -32,8 +32,7 @@ class OffscreenCanvas : public DOM::EventTarget
GC_DECLARE_ALLOCATOR(OffscreenCanvas);
public:
static GC::Ref<OffscreenCanvas> create(JS::Realm&, WebIDL::UnsignedLong width,
WebIDL::UnsignedLong height);
static GC::Ref<OffscreenCanvas> create(JS::Realm&, WebIDL::UnsignedLong width, WebIDL::UnsignedLong height);
static WebIDL::ExceptionOr<GC::Ref<OffscreenCanvas>> construct_impl(
JS::Realm&,
@ -50,7 +49,7 @@ public:
WebIDL::UnsignedLong width() const;
WebIDL::UnsignedLong height() const;
NonnullRefPtr<Gfx::Bitmap> bitmap() const;
RefPtr<Gfx::Bitmap> bitmap() const;
WebIDL::ExceptionOr<void> set_width(WebIDL::UnsignedLong);
WebIDL::ExceptionOr<void> set_height(WebIDL::UnsignedLong);
@ -69,7 +68,7 @@ public:
GC::Ptr<WebIDL::CallbackType> oncontextrestored();
private:
OffscreenCanvas(JS::Realm&, NonnullRefPtr<Gfx::Bitmap> bitmap);
OffscreenCanvas(JS::Realm&, RefPtr<Gfx::Bitmap> bitmap);
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
@ -85,7 +84,7 @@ private:
Variant<GC::Ref<HTML::OffscreenCanvasRenderingContext2D>, GC::Ref<WebGL::WebGLRenderingContext>, GC::Ref<WebGL::WebGL2RenderingContext>, Empty> m_context;
NonnullRefPtr<Gfx::Bitmap> m_bitmap;
RefPtr<Gfx::Bitmap> m_bitmap;
};
}