mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-28 19:59:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Add debug logging of reasons for layout tree update
Some checks are pending
CI / Lagom (arm64, Sanitizer_CI, false, macos-15, macOS, Clang) (push) Waiting to run
Details
CI / Lagom (x86_64, Fuzzers_CI, false, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Details
CI / Lagom (x86_64, Sanitizer_CI, false, ubuntu-24.04, Linux, GNU) (push) Waiting to run
Details
CI / Lagom (x86_64, Sanitizer_CI, true, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Details
Package the js repl as a binary artifact / build-and-package (arm64, macos-15, macOS, macOS-universal2) (push) Waiting to run
Details
Package the js repl as a binary artifact / build-and-package (x86_64, ubuntu-24.04, Linux, Linux-x86_64) (push) Waiting to run
Details
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Details
Lint Code / lint (push) Waiting to run
Details
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Details
Push notes / build (push) Waiting to run
Details

Browse source
This commit is contained in:
Andreas Kling 2025-04-19 10:49:33 +02:00 • committed by Andreas Kling
commit 545ed08519
Notes: github-actions[bot] 2025-04-20 22:32:03 +00:00
9 changed files with 68 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

29
Libraries/LibWeb/DOM/Node.cpp
View file

@ -229,7 +229,7 @@ void Node::set_text_content(Optional<String> const& maybe_content)
if (is_connected()) {
invalidate_style(StyleInvalidationReason::NodeSetTextContent);
set_needs_layout_tree_update(true);
set_needs_layout_tree_update(true, SetNeedsLayoutTreeUpdateReason::NodeSetTextContent);
}
document().bump_dom_tree_version();
@ -802,9 +802,9 @@ void Node::insert_before(GC::Ref<Node> node, GC::Ptr<Node> child, bool suppress_
if (is_connected()) {
if (layout_node() && layout_node()->display().is_contents() && parent_element()) {
parent_element()->set_needs_layout_tree_update(true);
parent_element()->set_needs_layout_tree_update(true, SetNeedsLayoutTreeUpdateReason::NodeInsertBeforeWithDisplayContents);
}
set_needs_layout_tree_update(true);
set_needs_layout_tree_update(true, SetNeedsLayoutTreeUpdateReason::NodeInsertBefore);
}
document().bump_dom_tree_version();
@ -913,7 +913,7 @@ void Node::remove(bool suppress_observers)
// NOTE: If we didn't have a layout node before, rebuilding the layout tree isn't gonna give us one
// after we've been removed from the DOM.
if (layout_node())
parent->set_needs_layout_tree_update(true);
parent->set_needs_layout_tree_update(true, SetNeedsLayoutTreeUpdateReason::NodeRemove);
}
// 11. Remove node from its parent’s children.
@ -1399,17 +1399,34 @@ EventTarget* Node::get_parent(Event const&)
return parent();
}
void Node::set_needs_layout_tree_update(bool value)
void Node::set_needs_layout_tree_update(bool value, SetNeedsLayoutTreeUpdateReason reason)
{
if (m_needs_layout_tree_update == value)
return;
m_needs_layout_tree_update = value;
if constexpr (UPDATE_LAYOUT_DEBUG) {
if (m_needs_layout_tree_update) {
// NOTE: We check some conditions here to avoid debug spam in documents that don't do layout.
auto navigable = this->navigable();
bool any_ancestor_needs_layout_tree_update = false;
for (auto* ancestor = parent_or_shadow_host(); ancestor; ancestor = ancestor->parent_or_shadow_host()) {
if (ancestor->needs_layout_tree_update()) {
any_ancestor_needs_layout_tree_update = true;
break;
}
}
if (!any_ancestor_needs_layout_tree_update && navigable && navigable->active_document() == &document()) {
dbgln("Need tree update ({}): {}", to_string(reason), debug_description());
}
}
}
// NOTE: If this is a shadow root, we need to propagate the layout tree update to the host.
if (is_shadow_root()) {
auto& shadow_root = static_cast<ShadowRoot&>(*this);
if (auto host = shadow_root.host())
host->set_needs_layout_tree_update(value);
host->set_needs_layout_tree_update(value, reason);
}
if (m_needs_layout_tree_update) {