LibWeb: Add debug logging of reasons for layout tree update
Some checks are pending
CI / Lagom (arm64, Sanitizer_CI, false, macos-15, macOS, Clang) (push) Waiting to run
CI / Lagom (x86_64, Fuzzers_CI, false, ubuntu-24.04, Linux, Clang) (push) Waiting to run
CI / Lagom (x86_64, Sanitizer_CI, false, ubuntu-24.04, Linux, GNU) (push) Waiting to run
CI / Lagom (x86_64, Sanitizer_CI, true, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Package the js repl as a binary artifact / build-and-package (arm64, macos-15, macOS, macOS-universal2) (push) Waiting to run
Package the js repl as a binary artifact / build-and-package (x86_64, ubuntu-24.04, Linux, Linux-x86_64) (push) Waiting to run
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Lint Code / lint (push) Waiting to run
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Push notes / build (push) Waiting to run

This commit is contained in:
Andreas Kling 2025-04-19 10:49:33 +02:00 committed by Andreas Kling
commit 545ed08519
Notes: github-actions[bot] 2025-04-20 22:32:03 +00:00
9 changed files with 68 additions and 19 deletions

View file

@ -108,6 +108,27 @@ enum class SetNeedsLayoutReason {
[[nodiscard]] StringView to_string(SetNeedsLayoutReason);
#define ENUMERATE_SET_NEEDS_LAYOUT_TREE_UPDATE_REASONS(X) \
X(ElementSetInnerHTML) \
X(HTMLInputElementSrcAttribute) \
X(HTMLObjectElementUpdateLayoutAndChildObjects) \
X(KeyframeEffect) \
X(NodeInsertBefore) \
X(NodeInsertBeforeWithDisplayContents) \
X(NodeRemove) \
X(NodeSetTextContent) \
X(None) \
X(SVGGraphicsElementTransformChange) \
X(StyleChange)
enum class SetNeedsLayoutTreeUpdateReason {
#define ENUMERATE_SET_NEEDS_LAYOUT_TREE_UPDATE_REASON(e) e,
ENUMERATE_SET_NEEDS_LAYOUT_TREE_UPDATE_REASONS(ENUMERATE_SET_NEEDS_LAYOUT_TREE_UPDATE_REASON)
#undef ENUMERATE_SET_NEEDS_LAYOUT_TREE_UPDATE_REASON
};
[[nodiscard]] StringView to_string(SetNeedsLayoutTreeUpdateReason);
class Node : public EventTarget
, public TreeNode<Node> {
WEB_PLATFORM_OBJECT(Node, EventTarget);
@ -307,7 +328,7 @@ public:
virtual bool is_child_allowed(Node const&) const { return true; }
[[nodiscard]] bool needs_layout_tree_update() const { return m_needs_layout_tree_update; }
void set_needs_layout_tree_update(bool);
void set_needs_layout_tree_update(bool, SetNeedsLayoutTreeUpdateReason);
[[nodiscard]] bool child_needs_layout_tree_update() const { return m_child_needs_layout_tree_update; }
void set_child_needs_layout_tree_update(bool b) { m_child_needs_layout_tree_update = b; }