From 54f1407177a3c075eaf74407b26e5febcf83cf03 Mon Sep 17 00:00:00 2001
From: Callum Law <callumlaw1709@outlook.com>
Date: Wed, 13 Aug 2025 16:34:59 +1200
Subject: [PATCH] LibWeb: Only associate transition with element once

We already handle this within the above call to `Animation::set_effect`

Gains us 3 WPT tests.
---
 Libraries/LibWeb/CSS/CSSTransition.cpp                      | 1 -
 .../css/css-transitions/CSSTransition-effect.tentative.txt  | 6 +++---
 .../css-transitions/CSSTransition-startTime.tentative.txt   | 5 ++---
 .../animations/transition-timing-function.txt               | 4 ++--
 4 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/Libraries/LibWeb/CSS/CSSTransition.cpp b/Libraries/LibWeb/CSS/CSSTransition.cpp
index f4673e93ea4..de036a1451c 100644
--- a/Libraries/LibWeb/CSS/CSSTransition.cpp
+++ b/Libraries/LibWeb/CSS/CSSTransition.cpp
@@ -117,7 +117,6 @@ CSSTransition::CSSTransition(JS::Realm& realm, DOM::Element& element, Optional<P
     set_timeline(element.document().timeline());
     set_owning_element(element);
     set_effect(m_keyframe_effect);
-    element.associate_with_animation(*this);
     element.set_transition(pseudo_element, m_transition_property, *this);
 
     HTML::TemporaryExecutionContext context(realm);
diff --git a/Tests/LibWeb/Text/expected/wpt-import/css/css-transitions/CSSTransition-effect.tentative.txt b/Tests/LibWeb/Text/expected/wpt-import/css/css-transitions/CSSTransition-effect.tentative.txt
index 256ddc876ab..63d9c15f56f 100644
--- a/Tests/LibWeb/Text/expected/wpt-import/css/css-transitions/CSSTransition-effect.tentative.txt
+++ b/Tests/LibWeb/Text/expected/wpt-import/css/css-transitions/CSSTransition-effect.tentative.txt
@@ -2,13 +2,13 @@ Harness status: OK
 
 Found 10 tests
 
-7 Pass
-3 Fail
+8 Pass
+2 Fail
 Pass	After setting a transition's effect to null, it still reports the original transition property
 Pass	After setting a transition's effect to null, it becomes finished
 Pass	After setting a transition's effect to null, style is updated
 Fail	After setting a transition's effect to null, a new transition can be started
-Fail	After setting a transition's effect to null, it should be possible to interrupt that transition
+Pass	After setting a transition's effect to null, it should be possible to interrupt that transition
 Pass	After setting a new keyframe effect with a shorter duration, the transition becomes finished
 Pass	After setting a new keyframe effect targeting different properties, the transition continues to report the original transition property
 Pass	After setting a new keyframe effect on a play-pending transition, the transition remains pending
diff --git a/Tests/LibWeb/Text/expected/wpt-import/css/css-transitions/CSSTransition-startTime.tentative.txt b/Tests/LibWeb/Text/expected/wpt-import/css/css-transitions/CSSTransition-startTime.tentative.txt
index aab11907ea2..5afb0af3d2f 100644
--- a/Tests/LibWeb/Text/expected/wpt-import/css/css-transitions/CSSTransition-startTime.tentative.txt
+++ b/Tests/LibWeb/Text/expected/wpt-import/css/css-transitions/CSSTransition-startTime.tentative.txt
@@ -2,10 +2,9 @@ Harness status: OK
 
 Found 5 tests
 
-4 Pass
-1 Fail
+5 Pass
 Pass	The start time of a newly-created transition is unresolved
-Fail	The start time of transitions is based on when they are generated
+Pass	The start time of transitions is based on when they are generated
 Pass	The start time of a transition can be set
 Pass	The start time can be set to seek a transition
 Pass	Seeking a transition using start time dispatches transition events
\ No newline at end of file
diff --git a/Tests/LibWeb/Text/expected/wpt-import/css/css-transitions/animations/transition-timing-function.txt b/Tests/LibWeb/Text/expected/wpt-import/css/css-transitions/animations/transition-timing-function.txt
index ad0b2fa4f76..1268c982a49 100644
--- a/Tests/LibWeb/Text/expected/wpt-import/css/css-transitions/animations/transition-timing-function.txt
+++ b/Tests/LibWeb/Text/expected/wpt-import/css/css-transitions/animations/transition-timing-function.txt
@@ -2,5 +2,5 @@ Harness status: OK
 
 Found 1 tests
 
-1 Fail
-Fail	Ensure that transition easing functions are properly applied.
\ No newline at end of file
+1 Pass
+Pass	Ensure that transition easing functions are properly applied.
\ No newline at end of file