From 54f6db01afbacbee1de0b437990ef33af0796e46 Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Mon, 28 Oct 2024 11:51:28 -0400 Subject: [PATCH] UI/Qt: Do not multiply window position/size by the device pixel ratio On macOS, this is resulting in values of window.screenX, window.screenY, window.outerWidth and window.outerHeight that are 2x larger than Safari, Firefox, and our AppKit UI. --- Ladybird/Qt/BrowserWindow.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Ladybird/Qt/BrowserWindow.cpp b/Ladybird/Qt/BrowserWindow.cpp index db1de920bc7..c864298837b 100644 --- a/Ladybird/Qt/BrowserWindow.cpp +++ b/Ladybird/Qt/BrowserWindow.cpp @@ -1168,7 +1168,7 @@ void BrowserWindow::resizeEvent(QResizeEvent* event) QWidget::resizeEvent(event); for_each_tab([&](auto& tab) { - tab.view().set_window_size({ frameSize().width() * m_device_pixel_ratio, frameSize().height() * m_device_pixel_ratio }); + tab.view().set_window_size({ frameSize().width(), frameSize().height() }); }); } @@ -1177,7 +1177,7 @@ void BrowserWindow::moveEvent(QMoveEvent* event) QWidget::moveEvent(event); for_each_tab([&](auto& tab) { - tab.view().set_window_position({ event->pos().x() * m_device_pixel_ratio, event->pos().y() * m_device_pixel_ratio }); + tab.view().set_window_position({ event->pos().x(), event->pos().y() }); }); }