mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-20 19:45:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibTLS: Call close() when we receive SSL_ERROR_ZERO_RETURN

Browse source 
If we don't do this, then we endlessly spin trying to read data which
ends up in a deadlock.

The description for SSL_ERROR_ZERO_RETURN states:
> The TLS/SSL connection has been closed. If the protocol version is SSL
> 3.0 or TLS 1.0, this result code is returned only if a closure alert
> has occurred in the protocol, i.e., if the connection has been closed
> cleanly. Note that in this case SSL_ERROR_ZERO_RETURN does not
> necessarily indicate that the underlying transport has been closed.
This commit is contained in:
rmg-x 2025-04-13 16:33:16 -05:00 • committed by Ali Mohammad Pur
parent b285202951
commit 555c8139d8
Notes: github-actions[bot] 2025-04-14 19:08:38 +00:00
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Libraries/LibTLS/TLSv12.cpp
View file

@ -58,6 +58,9 @@ ErrorOr<Bytes> TLSv12::read_some(Bytes bytes)
if (ret <= 0) {
switch (SSL_get_error(m_ssl, ret)) {
case SSL_ERROR_ZERO_RETURN:
if (auto const pending = TRY(pending_bytes()); pending > 0)
return Error::from_errno(EAGAIN);
close();
return Bytes { bytes.data(), 0 };
case SSL_ERROR_WANT_READ:
case SSL_ERROR_WANT_WRITE: