mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-26 22:38:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

AK: Port URL username/password from DeprecatedString to String

Browse source 
And for cases that just need to check whether the password/username is
empty, add a raw_{password,username} helper to avoid any allocation.
This commit is contained in:
Shannon Booth 2023-08-12 16:52:38 +12:00 • committed by Andrew Kaster
parent 6b29dc3e46
commit 55a01e72ca
Notes: sideshowbarker 2024-07-17 11:33:34 +09:00
11 changed files with 44 additions and 39 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibWeb/HTML/HTMLHyperlinkElementUtils.cpp
View file

@ -97,7 +97,7 @@ DeprecatedString HTMLHyperlinkElementUtils::username() const
return DeprecatedString::empty();
// 3. Return this element's url's username.
return m_url->username();
return m_url->username().release_value().to_deprecated_string();
}
// https://html.spec.whatwg.org/multipage/links.html#dom-hyperlink-username
@ -114,7 +114,7 @@ void HTMLHyperlinkElementUtils::set_username(DeprecatedString username)
return;
// 4. Set the username given this’s URL and the given value.
url->set_username(username);
MUST(url->set_username(username));
// 5. Update href.
update_href();
@ -134,7 +134,7 @@ DeprecatedString HTMLHyperlinkElementUtils::password() const
return DeprecatedString::empty();
// 4. Return url's password.
return url->password();
return url->password().release_value().to_deprecated_string();
}
// https://html.spec.whatwg.org/multipage/links.html#dom-hyperlink-password
@ -151,7 +151,7 @@ void HTMLHyperlinkElementUtils::set_password(DeprecatedString password)
return;
// 4. Set the password, given url and the given value.
url->set_password(move(password));
MUST(url->set_password(password));
// 5. Update href.
update_href();