mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-21 12:05:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Correct SVG smooth curve reflected control point calculation

Browse source 
We were calculating the reflected control points in the svg smooth
curve instructions incorrectly, and this issue was masked by the fact
that we were treating it as a relative coordinate in relative mode.
This commit is contained in:
Idan Horowitz 2022-03-04 20:53:32 +02:00 • committed by Andreas Kling
parent 6608812e4b
commit 55c247d044
Notes: sideshowbarker 2024-07-17 17:56:31 +09:00
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
Userland/Libraries/LibWeb/SVG/SVGPathElement.cpp
View file

@ -237,14 +237,17 @@ Gfx::Path& SVGPathElement::get_path()
m_previous_control_point = last_point;
}
auto reflected_previous_control_x = last_point.dx_relative_to(m_previous_control_point);
auto reflected_previous_control_y = last_point.dy_relative_to(m_previous_control_point);
// 9.5.2. Reflected control points https://svgwg.org/svg2-draft/paths.html#ReflectedControlPoints
// If the current point is (curx, cury) and the final control point of the previous path segment is (oldx2, oldy2),
// then the reflected point (i.e., (newx1, newy1), the first control point of the current path segment) is:
// (newx1, newy1) = (curx - (oldx2 - curx), cury - (oldy2 - cury))
auto reflected_previous_control_x = last_point.x() - m_previous_control_point.dx_relative_to(last_point);
auto reflected_previous_control_y = last_point.y() - m_previous_control_point.dy_relative_to(last_point);
Gfx::FloatPoint c1 = Gfx::FloatPoint { reflected_previous_control_x, reflected_previous_control_y };
Gfx::FloatPoint c2 = { data[0], data[1] };
Gfx::FloatPoint p2 = { data[2], data[3] };
if (!absolute) {
p2 += last_point;
c1 += last_point;
c2 += last_point;
}
path.cubic_bezier_curve_to(c1, c2, p2);