mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-01 05:39:11 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Implemented the CanvasRenderingContext2D::createImageData() spec

Browse source 
The only real change here is to use the absolute magnitude of the
width/height when creating the ImageData.

This fixes the crash on this WPT test:
https://wpt.fyi/results/html/canvas/element/pixel-manipulation/2d.imageData.create2.double.html?label=master&product=ladybird
This commit is contained in:
Cory Virok 2024-10-13 11:21:46 -07:00 • committed by Andreas Kling
commit 560c3824b9
Notes: github-actions[bot] 2024-10-14 06:26:10 +00:00
3 changed files with 33 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

18
Userland/Libraries/LibWeb/HTML/CanvasRenderingContext2D.cpp
View file

@ -321,9 +321,25 @@ void CanvasRenderingContext2D::fill(Path2D& path, StringView fill_rule)
fill_internal(path.path(), parse_fill_rule(fill_rule));
}
// https://html.spec.whatwg.org/multipage/canvas.html#dom-context-2d-createimagedata
WebIDL::ExceptionOr<JS::NonnullGCPtr<ImageData>> CanvasRenderingContext2D::create_image_data(int width, int height, Optional<ImageDataSettings> const& settings) const
{
return ImageData::create(realm(), width, height, settings);
// 1. If one or both of sw and sh are zero, then throw an "IndexSizeError" DOMException.
if (width == 0 || height == 0)
return WebIDL::IndexSizeError::create(realm(), "Width and height must not be zero"_string);
int abs_width = abs(width);
int abs_height = abs(height);
// 2. Let newImageData be a new ImageData object.
// 3. Initialize newImageData given the absolute magnitude of sw, the absolute magnitude of sh, settings set to settings, and defaultColorSpace set to this's color space.
auto image_data = TRY(ImageData::create(realm(), abs_width, abs_height, settings));
// 4. Initialize the image data of newImageData to transparent black.
// ... this is handled by ImageData::create()
// 5. Return newImageData.
return image_data;
}
// https://html.spec.whatwg.org/multipage/canvas.html#dom-context-2d-getimagedata