Everywhere: Mark GC::Cell derived classes as Weakable explicitly
Some checks are pending
CI / Lagom (arm64, Sanitizer_CI, false, macos-15, macOS, Clang) (push) Waiting to run
CI / Lagom (x86_64, Fuzzers_CI, false, ubuntu-24.04, Linux, Clang) (push) Waiting to run
CI / Lagom (x86_64, Sanitizer_CI, false, ubuntu-24.04, Linux, GNU) (push) Waiting to run
CI / Lagom (x86_64, Sanitizer_CI, true, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Package the js repl as a binary artifact / build-and-package (macos-14, macOS, macOS-universal2) (push) Waiting to run
Package the js repl as a binary artifact / build-and-package (ubuntu-24.04, Linux, Linux-x86_64) (push) Waiting to run
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Lint Code / lint (push) Waiting to run
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Push notes / build (push) Waiting to run

Previously, all `GC::Cell` derived classes were Weakable. Marking only
those classes that require this functionality as Weakable allows us to
reduce the memory footprint of some frequently used classes.
This commit is contained in:
Tim Ledbetter 2025-03-28 20:09:28 +00:00 committed by Andreas Kling
parent 11280897d3
commit 568531f06a
Notes: github-actions[bot] 2025-03-29 22:37:29 +00:00
7 changed files with 14 additions and 7 deletions

View file

@ -16,7 +16,8 @@
namespace Web::HTML {
class BrowsingContext final : public JS::Cell {
class BrowsingContext final : public JS::Cell
, public Weakable<BrowsingContext> {
GC_CELL(BrowsingContext, JS::Cell);
GC_DECLARE_ALLOCATOR(BrowsingContext);