mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-19 15:32:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

Everywhere: Mark GC::Cell derived classes as Weakable explicitly
Some checks are pending
CI / Lagom (arm64, Sanitizer_CI, false, macos-15, macOS, Clang) (push) Waiting to run
Details
CI / Lagom (x86_64, Fuzzers_CI, false, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Details
CI / Lagom (x86_64, Sanitizer_CI, false, ubuntu-24.04, Linux, GNU) (push) Waiting to run
Details
CI / Lagom (x86_64, Sanitizer_CI, true, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Details
Package the js repl as a binary artifact / build-and-package (macos-14, macOS, macOS-universal2) (push) Waiting to run
Details
Package the js repl as a binary artifact / build-and-package (ubuntu-24.04, Linux, Linux-x86_64) (push) Waiting to run
Details
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Details
Lint Code / lint (push) Waiting to run
Details
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Details
Push notes / build (push) Waiting to run
Details

Browse source 
Previously, all `GC::Cell` derived classes were Weakable. Marking only
those classes that require this functionality as Weakable allows us to
reduce the memory footprint of some frequently used classes.
This commit is contained in:
Tim Ledbetter 2025-03-28 20:09:28 +00:00 • committed by Andreas Kling
parent 11280897d3
commit 568531f06a
Notes: github-actions[bot] 2025-03-29 22:37:29 +00:00
7 changed files with 14 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibGC/Cell.h
View file

@ -36,7 +36,7 @@ public: \
} \ } \
friend class GC::Heap; friend class GC::Heap;
class Cell : public Weakable<Cell> { class Cell {
AK_MAKE_NONCOPYABLE(Cell); AK_MAKE_NONCOPYABLE(Cell);
AK_MAKE_NONMOVABLE(Cell); AK_MAKE_NONMOVABLE(Cell);

3
Libraries/LibJS/Runtime/Object.h
View file

@ -51,7 +51,8 @@ struct CacheablePropertyMetadata {
GC::Ptr<Object const> prototype; GC::Ptr<Object const> prototype;
}; };
class Object : public Cell { class Object : public Cell
, public Weakable<Object> {
GC_CELL(Object, Cell); GC_CELL(Object, Cell);
GC_DECLARE_ALLOCATOR(Object); GC_DECLARE_ALLOCATOR(Object);

6
Libraries/LibJS/Runtime/Shape.h
View file

@ -34,7 +34,8 @@ struct TransitionKey {
} }
}; };
class PrototypeChainValidity final : public Cell { class PrototypeChainValidity final : public Cell
, public Weakable<PrototypeChainValidity> {
GC_CELL(PrototypeChainValidity, Cell); GC_CELL(PrototypeChainValidity, Cell);
GC_DECLARE_ALLOCATOR(PrototypeChainValidity); GC_DECLARE_ALLOCATOR(PrototypeChainValidity);
@ -47,7 +48,8 @@ private:
size_t padding { 0 }; size_t padding { 0 };
}; };
class Shape final : public Cell { class Shape final : public Cell
, public Weakable<Shape> {
GC_CELL(Shape, Cell); GC_CELL(Shape, Cell);
GC_DECLARE_ALLOCATOR(Shape); GC_DECLARE_ALLOCATOR(Shape);

3
Libraries/LibWeb/HTML/BrowsingContext.h
View file

@ -16,7 +16,8 @@
namespace Web::HTML { namespace Web::HTML {
class BrowsingContext final : public JS::Cell { class BrowsingContext final : public JS::Cell
, public Weakable<BrowsingContext> {
GC_CELL(BrowsingContext, JS::Cell); GC_CELL(BrowsingContext, JS::Cell);
GC_DECLARE_ALLOCATOR(BrowsingContext); GC_DECLARE_ALLOCATOR(BrowsingContext);

3
Libraries/LibWeb/HTML/Navigable.h
View file

@ -34,7 +34,8 @@ struct TargetSnapshotParams {
}; };
// https://html.spec.whatwg.org/multipage/document-sequences.html#navigable // https://html.spec.whatwg.org/multipage/document-sequences.html#navigable
class Navigable : public JS::Cell { class Navigable : public JS::Cell
, public Weakable<Navigable> {
GC_CELL(Navigable, JS::Cell); GC_CELL(Navigable, JS::Cell);
GC_DECLARE_ALLOCATOR(Navigable); GC_DECLARE_ALLOCATOR(Navigable);

1
Libraries/LibWeb/Painting/PaintableBox.h
View file

@ -27,6 +27,7 @@ namespace Web::Painting {
extern bool g_paint_viewport_scrollbars; extern bool g_paint_viewport_scrollbars;
class PaintableBox : public Paintable class PaintableBox : public Paintable
, public Weakable<PaintableBox>
, public ClippableAndScrollable { , public ClippableAndScrollable {
GC_CELL(PaintableBox, Paintable); GC_CELL(PaintableBox, Paintable);

3
Services/WebContent/WebContentConsoleClient.h
View file

@ -16,7 +16,8 @@
namespace WebContent { namespace WebContent {
class WebContentConsoleClient : public JS::ConsoleClient { class WebContentConsoleClient : public JS::ConsoleClient
, public Weakable<WebContentConsoleClient> {
GC_CELL(WebContentConsoleClient, JS::ConsoleClient); GC_CELL(WebContentConsoleClient, JS::ConsoleClient);
GC_DECLARE_ALLOCATOR(WebContentConsoleClient); GC_DECLARE_ALLOCATOR(WebContentConsoleClient);