mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-30 20:59:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibJS: Check validity of computed_property_name() result before using it

Browse source 
This fixes two cases obj[expr] and obj[expr]() (MemberExpression and
CallExpression respectively) when expr throws an exception and results
in an empty value, causing a crash by passing the invalid PropertyName
created by computed_property_name() to Object::get() without checking it
first.

Fixes #3459.
This commit is contained in:
Linus Groh 2020-09-12 10:22:36 +01:00 • committed by Andreas Kling
commit 568d53c9b1
Notes: sideshowbarker 2024-07-19 02:44:41 +09:00
3 changed files with 17 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Libraries/LibJS/Tests/computed-property-throws.js Normal file
View file

@ -0,0 +1,8 @@
test("Issue #3459, exception in computed property expression", () => {
expect(() => {
"foo"[bar];
}).toThrow(ReferenceError);
expect(() => {
"foo"[bar]();
}).toThrow(ReferenceError);
});

2
Libraries/LibJS/Tests/exception-in-catch-block.js
View file

@ -1,4 +1,4 @@
test("Issue #1992, exception thrown in catch {} block", () => {
test("Issue #3437, exception thrown in catch {} block", () => {
var tryHasBeenExecuted = false;
var catchHasBeenExecuted = false;
var finallyHasBeenExecuted = false;