mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-28 19:59:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb/WebGL: Don't crash on unknown getParameter on the context

Browse source 
And allow the implementation to set the error code.
This commit is contained in:
Andrew Kaster 2024-12-05 23:30:17 -07:00 • committed by Alexander Kalenik
commit 56d45282ea
Notes: github-actions[bot] 2024-12-06 14:36:34 +00:00
3 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/WebGL/WebGL2RenderingContext.h
View file

@ -73,7 +73,7 @@ private:
GLenum m_error { 0 }; GLenum m_error { 0 };
void set_error(GLenum error); virtual void set_error(GLenum error) override;
}; };
} }

2
Libraries/LibWeb/WebGL/WebGLRenderingContext.h
View file

@ -72,7 +72,7 @@ private:
GLenum m_error { 0 }; GLenum m_error { 0 };
void set_error(GLenum error); virtual void set_error(GLenum error) override;
}; };
void fire_webgl_context_event(HTML::HTMLCanvasElement& canvas_element, FlyString const& type); void fire_webgl_context_event(HTML::HTMLCanvasElement& canvas_element, FlyString const& type);

5
Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateWebGLRenderingContext.cpp
View file

@ -231,7 +231,9 @@ static void generate_get_parameter(SourceGenerator& generator)
generator.appendln(R"~~~( generator.appendln(R"~~~(
default: default:
TODO(); dbgln("Unknown WebGL parameter name: {:x}", pname);
set_error(GL_INVALID_ENUM);
return JS::js_null();
})~~~"); })~~~");
} }
@ -389,6 +391,7 @@ public:
virtual void present() = 0; virtual void present() = 0;
virtual void needs_to_present() = 0; virtual void needs_to_present() = 0;
virtual void set_error(GLenum) = 0;
)~~~"); )~~~");
for (auto const& function : interface.functions) { for (auto const& function : interface.functions) {